From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B595096587 for ; Tue, 24 Jan 2023 16:37:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 967C06077 for ; Tue, 24 Jan 2023 16:37:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 24 Jan 2023 16:37:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AA2C645EBF for ; Tue, 24 Jan 2023 16:37:24 +0100 (CET) Message-ID: <1c15fff5-dfa8-c505-8754-1d5996f15a46@proxmox.com> Date: Tue, 24 Jan 2023 16:37:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: Thomas Lamprecht , Proxmox VE development discussion References: <20230123131735.400368-1-l.wagner@proxmox.com> <20230123131735.400368-3-l.wagner@proxmox.com> Content-Language: en-US From: Lukas Wagner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.967 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.148 Looks like a legit reply (A) RCVD_IN_DNSWL_HI -5 Sender listed at https://www.dnswl.org/, high trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 manager] ui: backup: replication: replace non-clickable checkbox with icons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2023 15:37:26 -0000 On 1/24/23 16:28, Thomas Lamprecht wrote: > > you break setting dataIndex by writing it all lowercase ?! > >> + align: 'center', >> + renderer: function(enabled, cell, record) { >> + return Proxmox.Utils.render_enabled_icon(record.data.enabled); >> + }, > > > with data index fixed, this could be: > > > renderer: Proxmox.Utils.renderEnabledIcon, > > Or if you really want to avoid passing the remaining params to the renderer: > > renderer: enabled => Proxmox.Utils.renderEnabledIcon(enabled), > > but normally that's really not a problem for renders. > Ooooh, and I kept wondering why `renderer` did not behave as in other places. Missspelled `dataIndex` must have snuck in as a copy-paste error, thanks for pointing this out. -- - Lukas