From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E8AC960E2B for ; Mon, 7 Feb 2022 14:51:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D920F256AC for ; Mon, 7 Feb 2022 14:51:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 66FB2256A1 for ; Mon, 7 Feb 2022 14:51:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1BDB6461D3 for ; Mon, 7 Feb 2022 14:45:28 +0100 (CET) Message-ID: <1c0137e7-2e3f-d99d-5c86-d02f283716e7@proxmox.com> Date: Mon, 7 Feb 2022 14:45:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas References: <20220207121825.722340-1-o.bektas@proxmox.com> From: Dylan Whyte In-Reply-To: <20220207121825.722340-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.399 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH pve-manager] NetworkEdit: allow setting 'mtu' option for guest network devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2022 13:51:49 -0000 Hi, Tested on Linux (Fedora 32 & Debian 11) and Windows 2019 server, and all seems to work. Best regards, Dylan On 2/7/22 13:18, Oguz Bektas wrote: > we already have the 'mtu' option inside the API, so we can just expose > that option inside the 'Advanced' menu for guest network interfaces. > > Signed-off-by: Oguz Bektas > --- > www/manager6/qemu/NetworkEdit.js | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js > index b39cffdc..4ce7e7a2 100644 > --- a/www/manager6/qemu/NetworkEdit.js > +++ b/www/manager6/qemu/NetworkEdit.js > @@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', { > me.network.macaddr = values.macaddr; > me.network.disconnect = values.disconnect; > me.network.queues = values.queues; > + me.network.mtu = values.mtu; > > if (values.rate) { > me.network.rate = values.rate; > @@ -112,6 +113,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', { > 'macaddr', > 'rate', > 'queues', > + 'mtu', > ]; > fields.forEach(function(fieldname) { > me.down('field[name='+fieldname+']').setDisabled(value); > @@ -161,6 +163,13 @@ Ext.define('PVE.qemu.NetworkInputPanel', { > value: '', > allowBlank: true, > }, > + { > + xtype: 'proxmoxintegerfield', > + name: 'mtu', > + fieldLabel: 'MTU', > + value: '', > + allowBlank: true, > + }, > ]; > > me.callParent(); Tested-by: Dylan Whyte