From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6FF3C9B41B for ; Wed, 24 May 2023 16:41:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 484D4216FC for ; Wed, 24 May 2023 16:41:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 24 May 2023 16:41:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8CA4E46E27 for ; Wed, 24 May 2023 16:41:04 +0200 (CEST) Message-ID: <1bdf402d-0b40-ce6e-265d-2db704352954@proxmox.com> Date: Wed, 24 May 2023 16:41:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Fiona Ebner , Proxmox VE development discussion References: <20230512124043.888785-1-a.lauterer@proxmox.com> <20230512124043.888785-5-a.lauterer@proxmox.com> <5124c3a2-5295-7a97-c9b8-60205682737c@proxmox.com> From: Aaron Lauterer In-Reply-To: <5124c3a2-5295-7a97-c9b8-60205682737c@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.089 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH qemu-server v2 4/6] tests: add migration alias check X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2023 14:41:35 -0000 On 5/22/23 16:25, Fiona Ebner wrote: > Am 12.05.23 um 14:40 schrieb Aaron Lauterer: >> @@ -355,6 +382,13 @@ my $source_vdisks = { >> 'vmid' => '111', >> 'volid' => 'local-zfs:vm-111-disk-0', >> }, >> + { >> + 'ctime' => '1589277334', >> + 'format' => 'raw', >> + 'size' => 4294967296, >> + 'vmid' => '123', >> + 'volid' => 'local-zfs:vm-123-disk-0', >> + }, > > A disk should also be added to alias-zfs. And actually, let's not make > alias-zfs reference "rpool/data", but add a second alias-zfs-2 or > something. Otherwise, we would need to add all disks currently in > local-zfs to alias-zfs too, to stay consistent with what we model. > good point. will do :) >> { >> 'format' => 'raw', >> 'name' => 'vm-4567-disk-0', >