From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A379462418 for ; Mon, 23 Nov 2020 13:10:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8E75928833 for ; Mon, 23 Nov 2020 13:09:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D53AF28828 for ; Mon, 23 Nov 2020 13:09:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9707743EFE for ; Mon, 23 Nov 2020 13:09:41 +0100 (CET) To: Proxmox VE development discussion , Stoiko Ivanov References: <20201123101229.18308-1-s.ivanov@proxmox.com> From: Thomas Lamprecht Message-ID: <1a855b57-beba-872b-34fe-0d302cd6d27a@proxmox.com> Date: Mon, 23 Nov 2020 13:09:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201123101229.18308-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.084 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, config.pm] Subject: [pve-devel] applied: [PATCH container] snapshot creation: only check volumes for fsfreeze X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Nov 2020 12:10:12 -0000 On 23.11.20 11:12, Stoiko Ivanov wrote: > fix #3161 >=20 > When considering mountpoints for running 'fsfreeze' before snapshot cre= ation, > commit 8463099d99273561c46398bf02206b4d9d431bc5 did not only consider > volumes created by our storage-stack, but also bindmounts and devmounts= > (directly mounting a blockdevice). >=20 > This led to PVE::Storage::parse_volume_id failing on those mountpoints.= >=20 > Since the fsfreeze call is best-effort and only run for specific > storageplugins, we can simply skip non-volume mountpoints, when gatheri= ng > the list of volumes to call fsfreeze on. >=20 > Tested with a container with a bindmount. >=20 > Signed-off-by: Stoiko Ivanov > --- > Sorry for that - will test my container patches with a more complete co= ntainer > config from now on :/ >=20 > src/PVE/LXC/Config.pm | 2 ++ > 1 file changed, 2 insertions(+) >=20 > applied, with Dominic's T-b tag thanks! Please prefix the `fix #ID:` in the commit subject and try to keep lines = shorter than 70 characters[0] [0]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Com= mit_Messages