From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CCF298D744 for ; Tue, 8 Nov 2022 18:27:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AEE34B1A2 for ; Tue, 8 Nov 2022 18:27:15 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 8 Nov 2022 18:27:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D04FD4105D for ; Tue, 8 Nov 2022 18:27:13 +0100 (CET) Message-ID: <1a443a48-8aac-5480-09f0-7df193c69cc0@proxmox.com> Date: Tue, 8 Nov 2022 18:27:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= References: <20210908100427.3166320-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210908100427.3166320-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.033 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm] Subject: [pve-devel] applied: [RFC container] fix #3606: drop --inplace from suspend backups X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Nov 2022 17:27:15 -0000 Am 08/09/2021 um 12:04 schrieb Fabian Gr=C3=BCnbichler: > for bullseye-based systems, the 'fs.protected_regular'[0] sysctl is set= > to '2' by default[1] (as opposed to the old value of '0'). this breaks > rsync's `--inplace` mode for such protected files, since opening them > with O_CREAT is not even possible for the root user anymore. >=20 > one example in the wild are debian (-based) containers using PHP, where= > the session dir '/var/lib/php/sessions' is sticky, world-writable, owne= d > by root and contains sessions files usually owned by www-data. if any o= f > these session files are modified between the first and second rsync run= , > the second run and thus the backup will fail. >=20 > the downside of this change is that containers with large files that ar= e > updated between the first and second run will now see more (temp) space= > usage - but suspend mode is not space efficient anyway and such setups > should consider switching to snapshot mode anyway. >=20 > additionaly, this commit drops the now no longer needed $first paramete= r > previously used to decide between different parameters for first and > second rsync run. >=20 > 0: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/c= ommit/?id=3D30aba6656f61ed44cba445a3c0d38b296fa9e8f5 > 1: https://salsa.debian.org/debian/procps/-/commit/299f4a1a10810e2995e6= 66374b880b543af8e8e4 >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- > RFC in case anybody has a better solution other than setting the sysctl= > to 0 again ;) doesn't seems like anybody could come up with something better... >=20 > src/PVE/VZDump/LXC.pm | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) >=20 > applied, thanks!