public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons
Date: Wed, 20 May 2026 14:53:59 +0200	[thread overview]
Message-ID: <19ded4fa-ce27-4ee8-a9d5-9fb2f8c57e53@proxmox.com> (raw)
In-Reply-To: <20260520124601.520864-1-a.bied-charreton@proxmox.com>

i guess this could be ok if it works,
but i really dislike having to add 1 to 2 attributes
per passwordmanager... isn't the generic 'autocomplete=off' enough?


On 5/20/26 2:45 PM, Arthur Bied-Charreton wrote:
> Password manager extensions scan every new <input> element. The flag
> selector grid creates hundreds of radio buttons through its
> widgetcolumn, causing the extension to peg the CPU while it checks each
> one for autofill.
> 
> Mark the radio inputs with autocomplete="off" and the extension-specific
> ignore attributes so they are skipped during the scan.
> 
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>   www/manager6/form/VMCPUFlagSelector.js | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index ea20108d..f8d4caad 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -263,16 +263,19 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>                           boxLabelAlign: 'before',
>                           inputValue: '-',
>                           isFormField: false,
> +                        inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"',
>                       },
>                       {
>                           checked: true,
>                           inputValue: '=',
>                           isFormField: false,
> +                        inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"',
>                       },
>                       {
>                           boxLabel: '+',
>                           inputValue: '+',
>                           isFormField: false,
> +                        inputAttrTpl: 'autocomplete="off" data-bwignore data-1p-ignore data-lpignore="true"',
>                       },
>                   ],
>               },





  reply	other threads:[~2026-05-20 12:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 12:46 [PATCH pve-manager] ui: cpu flags: make password managers ignore flag radio buttons Arthur Bied-Charreton
2026-05-20 12:53 ` Dominik Csapak [this message]
2026-05-20 12:58   ` David Riley
2026-05-20 13:08     ` David Riley
2026-05-20 13:43 ` Thomas Lamprecht
2026-05-20 14:07   ` Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19ded4fa-ce27-4ee8-a9d5-9fb2f8c57e53@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal