From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C7B417120D for ; Wed, 8 Jun 2022 12:14:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AF8B6687C for ; Wed, 8 Jun 2022 12:14:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DBC616870 for ; Wed, 8 Jun 2022 12:14:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B8FB443693; Wed, 8 Jun 2022 12:14:03 +0200 (CEST) Message-ID: <199d2486-e9ba-f943-bea3-0f57c4f6c753@proxmox.com> Date: Wed, 8 Jun 2022 12:13:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, aderumier@odiso.com References: <20220516160719.3818057-1-aderumier@odiso.com> <20220516160719.3818057-8-aderumier@odiso.com> From: Fabian Ebner In-Reply-To: <20220516160719.3818057-8-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.927 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.732 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemu.pm, qemuconfig.pm, abstractconfig.pm] Subject: Re: [pve-devel] [PATCH v5 qemu-server 7/9] api2: qemu : don't display cloudinit value X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 10:14:35 -0000 Am 16.05.22 um 18:07 schrieb Alexandre Derumier: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/Qemu.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm > index 1d5b66f..57a75fc 100644 > --- a/PVE/API2/Qemu.pm > +++ b/PVE/API2/Qemu.pm > @@ -1227,6 +1227,7 @@ __PACKAGE__->register_method({ > $conf = PVE::QemuConfig->load_current_config($param->{vmid}, $param->{current}); It'd be a bit nicer to have load_current_config() not return the cloudinit section. And because the implementation in AbstractConfig.pm shouldn't need to know about the cloudinit section, I think we should override load_current_config() in QemuConfig.pm (calling the parent method and removing the cloudinit section there). > } > $conf->{cipassword} = '**********' if $conf->{cipassword}; > + delete $conf->{cloudinit}; > return $conf; > > }});