From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B5D531FF172 for <inbox@lore.proxmox.com>; Wed, 16 Apr 2025 10:46:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3DCB630B35; Wed, 16 Apr 2025 10:46:43 +0200 (CEST) Date: Wed, 16 Apr 2025 10:46:39 +0200 (CEST) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Message-ID: <1964246391.2072.1744793199860@webmail.proxmox.com> In-Reply-To: <mailman.1000.1744715821.359.pve-devel@lists.proxmox.com> References: <mailman.1000.1744715821.359.pve-devel@lists.proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev75 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] Migration of VM/Container on custom storage type X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Max Schettler <max@simplyblock.io> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> > Max Schettler via pve-devel <pve-devel@lists.proxmox.com> hat am 15.04.2025 11:55 CEST geschrieben: > Hi, > > I'm developing a Proxmox storage plugin. Trying to use the > high-availability features or migrating VMs/Containers to another > hypervisor in the cluster I get error messages about the storage type > I'm providing not being supported. Hi! thanks for reaching out! out of interest, what is the storage plugin for? in general it always helps to provide a bit of detail and to include all error messages. I made an educated guess below what your issue is, if it is not correct, please just add more details and I am sure we can figure it out. > Looking at the source, it seems like there is a whitelist of > storagetypes, and no feature check like e.g. for snapshotting. Am I > right to assume there is currently no way of providing a storage backend > that can use this functionality? Are there details beyond this check > that prevent this possibility? at the moment there is a list of shared storage types in PVE::Storage::Plugin that is used to set the shared flag on the storage instance (which in turn makes migrations ignore volumes there since a storage being shared means its volumes have identical content on all nodes where the storage is available). the only option at the moment is to add your type to that list (it is shared state across all plugins, so any plugin can do so). > If I am reading the code correctly, are there plans to extend the Plugin > API s.t. it becomes an option? Providing this feature would be an > important addition to our plugin. I think we will switch to just making this a property of the plugin in a declarative fashion as part of revamping the plugin interface, but that has not happened yet, so for now the only option to add a new shared plugin is to push to that list. you might be interested Max (still open/iterated upon) series documenting and improving the plugin interface: https://lore.proxmox.com/pve-devel/20250326142059.261938-1-m.carrara@proxmox.com/ while some parts are still in flux there, it should give some missing details! Fabian _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel