From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B0CC7626E4 for ; Fri, 21 Aug 2020 10:42:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AC426B104 for ; Fri, 21 Aug 2020 10:41:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 01B49B0F7 for ; Fri, 21 Aug 2020 10:41:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BA5004477D for ; Fri, 21 Aug 2020 10:41:34 +0200 (CEST) To: Proxmox VE development discussion , Stoiko Ivanov References: <20200821080738.30247-1-s.ivanov@proxmox.com> From: Thomas Lamprecht Message-ID: <195158fd-2f27-a2b9-3bf4-d8bc8eb4ed26@proxmox.com> Date: Fri, 21 Aug 2020 10:41:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Thunderbird/80.0 MIME-Version: 1.0 In-Reply-To: <20200821080738.30247-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.080 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, qemuserver.pm] Subject: [pve-devel] applied: [PATCH qemu-server] print_vga_device: check if bios is defined X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Aug 2020 08:42:05 -0000 On 21.08.20 10:07, Stoiko Ivanov wrote: > Otherwise a warning is printed if the bios is not set in the config. > > reported via community forum: > https://forum.proxmox.com/threads/warning-in-qemuserver.74683/ > > reproduced and tested that the patch fixes the issue. > > Signed-off-by: Stoiko Ivanov > --- > PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! Followed up with increasing the cfg2cmd regression test coverage for warnings, as it catches such things then. https://lists.proxmox.com/pipermail/pve-devel/2020-August/044734.html