From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <c.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 50EAF9BA3D
for <pve-devel@lists.proxmox.com>; Tue, 21 Nov 2023 12:11:03 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 330867268
for <pve-devel@lists.proxmox.com>; Tue, 21 Nov 2023 12:10:33 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Tue, 21 Nov 2023 12:10:32 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 09CB340F56
for <pve-devel@lists.proxmox.com>; Tue, 21 Nov 2023 12:10:32 +0100 (CET)
Date: Tue, 21 Nov 2023 12:10:31 +0100 (CET)
From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Message-ID: <1944551386.465.1700565031150@webmail.proxmox.com>
In-Reply-To: <1925251120.455.1700564597724@webmail.proxmox.com>
References: <20231121090012.23571-1-c.ebner@proxmox.com>
<5b15cdca-9203-469a-8a6f-8922db178302@proxmox.com>
<1925251120.455.1700564597724@webmail.proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev54
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.053 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH pve-manager] ui: node summary: use SI units
for HD usage
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 21 Nov 2023 11:11:03 -0000
> On 21.11.2023 12:03 CET Christian Ebner <c.ebner@proxmox.com> wrote:
>
>
> > On 21.11.2023 11:05 CET Fiona Ebner <f.ebner@proxmox.com> wrote:
> >
> >
> > Am 21.11.23 um 10:00 schrieb Christian Ebner:
> > > diff --git a/www/manager6/node/StatusView.js b/www/manager6/node/StatusView.js
> > > index d34724f7..a6975b6e 100644
> > > --- a/www/manager6/node/StatusView.js
> > > +++ b/www/manager6/node/StatusView.js
> > > @@ -72,7 +72,9 @@ Ext.define('PVE.node.StatusView', {
> > > title: '/ ' + gettext('HD space'),
> > > valueField: 'rootfs',
> > > maxField: 'rootfs',
> > > - renderer: Proxmox.Utils.render_node_size_usage,
> > > + renderer: function(record) {
> > > + return Proxmox.Utils.render_size_usage(record.used, record.total, true);
> > > + },
> >
> > Would it make more sense to change render_node_size_usage directly? Then
> > PMG and PBS would also get the change. Like this, it will be
> > inconsistent between the products, or?
>
> render_node_size_usage is used also for rendering memory size information, where we want IEC units.
>
> Therefore, my initial approach was adding the `useSI` parameter to `render_node_size_usage` as second parameter, which however breaks all the other renderer invocations, I assume because the renderer invocation passes along multiple parameters.
>
> This is why I opted for the invocation as is.
>
> PBS already shows the HD usage values in SI units.
>
> Cheers,
> Chris
Checked also how this is handled in PBS, also there the `render_size_usage` is invoked, see [0].
[0] https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=www/panel/NodeInfo.js;h=2551c9a55ba18a8cb6dbc095df94b650ed25eda2;hb=HEAD#l117