From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7B8C56A55B for ; Fri, 30 Jul 2021 15:19:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 71D1211EAD for ; Fri, 30 Jul 2021 15:19:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 73D1E11E9F for ; Fri, 30 Jul 2021 15:19:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 490FA42C7C for ; Fri, 30 Jul 2021 15:19:24 +0200 (CEST) Message-ID: <1831370b-c762-7761-cf85-3814d8fe477a@proxmox.com> Date: Fri, 30 Jul 2021 15:19:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.0 Content-Language: en-GB To: Proxmox VE development discussion , Lorenz Stechauner References: <20210722130631.237107-1-l.stechauner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210722130631.237107-1-l.stechauner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.479 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.202 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [anyevent.pm, status.pm] Subject: Re: [pve-devel] [PATCH-SERIES v2 http-server/storage/manager] add checksum and algorithm to iso upload X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jul 2021 13:19:25 -0000 On 22/07/2021 15:06, Lorenz Stechauner wrote: > changes to v1: > * dropped commits, that were already applied in the mean time > * better commit messages > * dropped the 'new-filename' - using 'filename' instead > * error handling for unlink > * dropped check for `new FormData()` in pve-manager > * fixed commit for pve-http-server (deleting temp file on errors) > * check file extention in front end too > > note: two commits in total state, that they break/require some > versions of other repos. please do not forget to bump those and > create the accoring 'breaks' or 'requires'. > > > pve-http-server: > Lorenz Stechauner (1): > anyevent: move unlink from http-server to endpoint > > src/PVE/APIServer/AnyEvent.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > > pve-storage: > Lorenz Stechauner (3): > status: move unlink from http-server to enpoint > status: remove sleep(1) in file upload > status: add checksum and algorithm to file upload > > PVE/API2/Storage/Status.pm | 44 +++++++++++++++++++++++++++++++------- > 1 file changed, 36 insertions(+), 8 deletions(-) > > > pve-manager: > Lorenz Stechauner (5): > ui: move upload window into UploadToStorage.js > ui: refactor UploadToStorage.js > ui/UploadToStorage: add checksum and algorithm > ui/UploadToStorage: add TaskViewer > ui/UplaodToStorage: check file extension > > www/manager6/Makefile | 1 + > www/manager6/storage/ContentView.js | 197 +--------------- > www/manager6/window/UploadToStorage.js | 311 +++++++++++++++++++++++++ > 3 files changed, 314 insertions(+), 195 deletions(-) > create mode 100644 www/manager6/window/UploadToStorage.js > Two small nits I found when doing a shallow "smell test" review, else the direction looks OK. I do not want to tackle a in-depth review/test _and_ the two breaks in dependencies a day before my vacation, so I'm letting Fabian handle this, which has a better eye for those dependencies most of the time any way. The GUI can be reviewed by Dominik.