From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 13E631FF16E
for <inbox@lore.proxmox.com>; Mon, 3 Mar 2025 10:39:04 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 680D3627A;
Mon, 3 Mar 2025 10:38:59 +0100 (CET)
Date: Mon, 3 Mar 2025 10:38:55 +0100 (CET)
From: Alexander Abraham <a.abraham@proxmox.com>
To: Shannon Sterz <s.sterz@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <1809667534.2948.1740994735366@webmail.proxmox.com>
In-Reply-To: <D7Y7DJ4Y5JAT.KAPGBO9UNXY2@proxmox.com>
References: <20250220143745.135908-1-a.abraham@proxmox.com>
<D7Y7DJ4Y5JAT.KAPGBO9UNXY2@proxmox.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev74
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.075 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_SBL_A 0.1 Contains URL's A record listed in the Spamhaus SBL blocklist
[142.250.185.206]
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] Updated Gradle version
and some build dependencies.
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Hi Shannon,
sorry I only just saw this now. (Keeping up with all the emails coming in is something I still need to get on top of.) At the time this was an oversight on my part. Apologies for this. I was trying to get the build working and used a suggestion I saw in an old forum post of someone who was having the same problem. For them, specifying the namespace was the missing piece for getting the build to work.
Best,
Alexander
> Shannon Sterz <s.sterz@proxmox.com> hat am 21.02.2025 15:45 CET geschrieben:
>
>
> On Thu Feb 20, 2025 at 3:37 PM CET, Alexander Abraham wrote:
> > The Flutter frontend of PVE was not compilable for Android
> > with the versions of different tools set in the project files.
> > The versions of the tools causing this problem was updated
> > and the app compiles for Android.
> >
> > Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> > ---
> > android/app/build.gradle | 10 +++++++++-
> > android/gradle/wrapper/gradle-wrapper.properties | 2 +-
> > android/settings.gradle | 4 ++--
> > 3 files changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git a/android/app/build.gradle b/android/app/build.gradle
> > index 4f827a5..59c318d 100644
> > --- a/android/app/build.gradle
> > +++ b/android/app/build.gradle
> > @@ -45,6 +45,7 @@ def keystoreSecret = System.getenv('PROXMOX_APP_KEYSTORE_SECRET')
> >
> > android {
> > compileSdkVersion 34
> > + namespace = "com.proxmox.app.pve_flutter_frontend"
>
> i haven't tested this, don't have a flutter setup here, but the
> inconsistent use of "=" seems strange to me. looking at the android
> documentation you are supposed to use either "=" consistently in a
> build.gradle.kts file or not in a build.gradle file.
>
> did you mix them intentionally?
>
> [1]: https://developer.android.com/build/gradle-build-overview#kts
>
> >
> > sourceSets {
> > main.java.srcDirs += 'src/main/kotlin'
> > @@ -52,7 +53,7 @@ android {
> >
> >
> > defaultConfig {
> > - applicationId "com.proxmox.app.pve_flutter_frontend"
> > + applicationId namespace
> > minSdkVersion 23
> > targetSdkVersion 34
> > versionCode flutterVersionCode.toInteger()
> > @@ -74,9 +75,16 @@ android {
> > signingConfig signingConfigs.release
> > }
> > }
> > + compileOptions {
> > + sourceCompatibility JavaVersion.VERSION_17
> > + targetCompatibility JavaVersion.VERSION_17
> > + }
> > lint {
> > disable 'InvalidPackage'
> > }
> > + kotlinOptions{
> > + jvmTarget = '17'
> > + }
> > }
> >
> > flutter {
> > diff --git a/android/gradle/wrapper/gradle-wrapper.properties b/android/gradle/wrapper/gradle-wrapper.properties
> > index 0732d12..90d1364 100644
> > --- a/android/gradle/wrapper/gradle-wrapper.properties
> > +++ b/android/gradle/wrapper/gradle-wrapper.properties
> > @@ -1,6 +1,6 @@
> > #Mon Apr 24 14:18:06 CEST 2023
> > distributionBase=GRADLE_USER_HOME
> > distributionPath=wrapper/dists
> > -distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-bin.zip
> > +distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip
> > zipStoreBase=GRADLE_USER_HOME
> > zipStorePath=wrapper/dists
> > diff --git a/android/settings.gradle b/android/settings.gradle
> > index 4fc86fd..1da49ad 100644
> > --- a/android/settings.gradle
> > +++ b/android/settings.gradle
> > @@ -18,8 +18,8 @@ pluginManagement {
> >
> > plugins {
> > id "dev.flutter.flutter-plugin-loader" version "1.0.0"
> > - id "com.android.application" version "7.4.2" apply false
> > - id "org.jetbrains.kotlin.android" version "1.7.20" apply false
> > + id "com.android.application" version "8.7.0" apply false
> > + id "org.jetbrains.kotlin.android" version "1.8.22" apply false
> > }
> >
> > include ':app'
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel