From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 239B87026F for ; Mon, 13 Jun 2022 10:35:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1B306866D for ; Mon, 13 Jun 2022 10:34:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AFC888662 for ; Mon, 13 Jun 2022 10:34:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8853642357 for ; Mon, 13 Jun 2022 10:34:31 +0200 (CEST) Message-ID: <17eeff56-36ee-ce2a-6a1c-5da69a2cc01d@proxmox.com> Date: Mon, 13 Jun 2022 10:34:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, d.tschlatscher@proxmox.com References: <20220520132859.144041-1-d.tschlatscher@proxmox.com> <20220520132859.144041-4-d.tschlatscher@proxmox.com> From: Fabian Ebner In-Reply-To: <20220520132859.144041-4-d.tschlatscher@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.917 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.732 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH storage v3 4/4] Added a LOG_EXT constant as a counterpart to NOTES_EXT X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jun 2022 08:35:02 -0000 Am 20.05.22 um 15:28 schrieb Daniel Tschlatscher: > diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm > index 0a100b7..7e53189 100644 > --- a/PVE/Storage/Plugin.pm > +++ b/PVE/Storage/Plugin.pm > @@ -21,6 +21,7 @@ use base qw(PVE::SectionConfig); > use constant COMPRESSOR_RE => 'gz|lzo|zst'; > > use constant NOTES_EXT => ".notes"; > +use constant LOG_EXT => ".log"; Nit: not ordered alphabetically