From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5EC8964957 for ; Fri, 28 Jan 2022 13:24:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 50EA42E79C for ; Fri, 28 Jan 2022 13:23:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C73C22E791 for ; Fri, 28 Jan 2022 13:23:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A6A704008C for ; Fri, 28 Jan 2022 13:23:36 +0100 (CET) Message-ID: <17b097ae-9d93-b08b-1de9-6653571f5130@proxmox.com> Date: Fri, 28 Jan 2022 13:23:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:97.0) Gecko/20100101 Thunderbird/97.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20220124170340.1858708-1-a.lauterer@proxmox.com> <20220125085153.1451323-1-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220125085153.1451323-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.061 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCHi v3 manager] fix #3451 ui: ceph create osd: show custom device classes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 12:24:07 -0000 On 25.01.22 09:51, Aaron Lauterer wrote: > Showing already configured custom device classes makes it easier to > create new OSDs with custom device classes. > > The Crush map contains a list of all OSDs in the cluster, including > their device class. > This means we can create a list of used device classes from it, avoiding > adding another API endpoint. > > Fetching the crushmap should also be quite a bit less data that needs to > be transferred, compared to the other possible nodes//ceph/osd > endpoint, especially in larger clusters. > > Signed-off-by: Aaron Lauterer > --- > changes from v2: > - check against eslint warnings, adding two commas > > changes from v1: > - template string for API call > - API failure now throws an alert > - used Thomas idea on how to make the list creation more concise and > only update the combo items if we do have custom device classes > - reverted default `comboItems` to the element definition > > @Thomas by using `Array.from` we can iterate over the results returned > from matchAll and also map element [1] from the returned array as it > actually holds the matched item. > The unshift needed the `...` deconstruction operator as comboItems is an > array of arrays. I actually dropped the unshift and expanded directly: kvField.setComboItems([...kvField.comboItems, ...classes]); In theory this could allow a minimally slightly more efficient use, not that it'd matter here much, but hey a line less code ;-P > > www/manager6/ceph/OSD.js | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > applied, thanks!