From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id F16AA1FF0AF for ; Fri, 20 Nov 2026 15:33:56 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C6BB4217A6; Fri, 20 Nov 2026 15:33:54 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Thomas Lamprecht Subject: applied: [PATCH qemu] fix #8343, #8361: avoid QMP timeouts and VM stalls in backups of RBD disks Date: Fri, 20 Nov 2026 15:26:29 +0100 Message-ID: <179518478542.209609.6419724984138342796.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120113834.4069058-1-t.lamprecht@proxmox.com> References: <20261120113834.4069058-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795185231654 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.248 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MSGMGOJR4U46PKBZ5XONSZ6DLIHKOBN7 X-Message-ID-Hash: MSGMGOJR4U46PKBZ5XONSZ6DLIHKOBN7 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 20 Nov 2026 12:38:01 +0100, Thomas Lamprecht wrote: > For an RBD image with fast-diff, a backup queries the block status of > each chunk, and each query waits until the requests in flight on the > image have completed. For a disk without an iothread, QEMU waited for > that in its main loop. Since pve-qemu-kvm 11.1.3-2, backups to a > Proxmox Backup Server process chunks in parallel, which keeps more > reads in flight and so makes these waits longer. The guest could stall > meanwhile, and a backup failed when one of its QMP commands timed out. > > [...] Applied, thanks! I slightly worried about qemu_rbd_co_block_status() now yielding could break some assumption, but I couldn't find anything and qcow2_co_block_status() can already yield too, so there is a precedent. Still, it might be nice to propose this change upstream too for additional feedback and diverging less. [1/1] fix #8343, #8361: avoid QMP timeouts and VM stalls in backups of RBD disks commit: cdca0ab83cd4dd8b36cb1f528f12ab4bafe94854