From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id F05F71FF0AF for ; Fri, 20 Nov 2026 08:43:05 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D80A0216D8; Fri, 20 Nov 2026 08:42:54 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, David Riley Subject: Re: [PATCH access-control/manager/network v5 0/6] fix #7294: pool: add SDN VNets as pool members Date: Fri, 20 Nov 2026 08:42:39 +0100 Message-ID: <179515721895.2281522.9098172508007955674.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261119124731.84602-1-d.riley@proxmox.com> References: <20261119124731.84602-1-d.riley@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795160569074 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: J545RWHICQTQXEU66YHT332Y5SL2E2V3 X-Message-ID-Hash: J545RWHICQTQXEU66YHT332Y5SL2E2V3 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 19 Nov 2026 13:47:25 +0100, David Riley wrote: > Maintainer Note: > > This patch requires version bumps: > * pve-access-control > * pve-manager > * pve-network > > [...] Applied, thanks! Tested adding, moving and removing VNet pool members on a three-node cluster. What I changed in your patches: - A member added while an SDN apply deleted or moved its VNet was missed and stayed in the pool forever. Changes to network members now take the SDN domain lock, so they can't overlap with an apply. - The API descriptions now explain the three member forms and that they only control which network devices can be configured. I also made the naming consistent and the dialog labels clearer. - The ID patterns now end with \z instead of $, so they no longer accept a trailing newline (yeah, its a stupid design, I know...). What I added on top: - The pool index returned network members only by ID, while guests and storages also have 'vmid' and 'storage'. Network members now get a 'network' property and a 'network/' ID prefix, to settle this before the release. - pve-sdn-commit did not take the SDN domain lock at boot, so it could clash with an apply or a pool change. It now does, and still applies the config locally if that fails, but marks the unit as failed. - The user docs now cover VNets in pools. Still open: - The VNet member key is parsed in several places; a shared helper in PVE::AccessControl might be nice. - The VLAN tag and propagate fields could be disabled for VNets that aren't VLAN-aware. - The dialog offers VNets that aren't applied yet, but the API only accepts applied ones. [pve-access-control] [1/6] rpcenv: allow SDN.Allocate to modify permissions on SDN paths commit: 74748664eb8299e9b5d31fcbda04922b29a300f4 [pve-manager] [4/6] ui: replace var with let to match style guide for variable declaration commit: b9a0f503a4d1615c5956cb88c6f0df0470c9bbc8 [5/6] fix #7294: api: pool: add SDN VNets as pool members commit: 948e075031ca0705b3997f459fe619c22b222994 [6/6] fix #7294: ui: pool: add SDN VNets as pool members commit: 69ba33f18e31342c68cd395d56cdc4b5af340a0d [pve-network] [2/6] sdn: register api formats for zones and vnets commit: 5016945a918c22e8b264f327511dc9afc9428567 [3/6] fix #7294: sdn: vnet: update pool members on VNet zone change and deletion commit: 27afd386382a00a187883c27bb8e358c1fd0c1e9