From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 86CC41FF0AA for ; Tue, 17 Nov 2026 14:01:32 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 1BEC6215CC; Tue, 17 Nov 2026 14:01:28 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com, =?UTF-8?q?Michael=20K=C3=B6ppl?= Subject: applied: [PATCH many v8 00/22] add option to prevent suggesting previously used VMIDs Date: Tue, 17 Nov 2026 14:00:21 +0100 Message-ID: <179491124305.47911.7338085357671617679.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261012154600.877830-1-m.koeppl@proxmox.com> References: <20261012154600.877830-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794920482559 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.127 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XQ6DXZVY7NJNNJSHCWEAUVKY54RBJ2BG X-Message-ID-Hash: XQ6DXZVY7NJNNJSHCWEAUVKY54RBJ2BG X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 12 Oct 2026 17:45:38 +0200, Michael Köppl wrote: > This is based on the original series [0] by Severen Redwood and Daniel > Krambrock. It is rebased on the latest master branches and incorporates > the feedback from v7 [3]. > > The last patch for cluster and the last two for guest-common and manager > add the optional enforcement of the next-id settings. The rest of the > series works without them. Since IDs are recorded before a guest exists > and stay recorded if its creation fails, retrying a failed creation > with the same ID is rejected when both 'enforce' and 'unique' are set. > > [...] Applied, thanks for your work on this long-requested feature! [01/22] cluster files: add virtual-guest/used-guest-ids commit: cf879e6f58357cef6450f449e37776f424d14a3e [02/22] datacenter config: add unique subproperty to next-id commit: d60e1b03ddbc578905233ba61797acf4fa6eb2ff [03/22] datacenter config: next-id: add enforce subproperty commit: c005fb9a66103909c33bba16a7adbef260cfbc32 [04/22] src/makefile: order files alphabetically commit: 42bda85bc1646587f907f702656661c8f3c6f6c2 [05/22] add module to track previously used guest IDs commit: 6f72a327e7ff0b1696e48aadf3763dfa1ed15291 [06/22] tests: add tests for used guest ID tracking commit: fe3629ae65a7962552270cdb95a071a39030a1cb [07/22] abstract config: register used guest ID when creating config commit: 412a1c3a40e0cbe5ce8ab98003e6ed348516076a [08/22] guest id: keep used ID list below the pmxcfs file size limit commit: ca7ac83babff8c45ea751f9ddbaf267a1efdf690 [09/22] tests: add tests for used-guest-ids max file size handling commit: 926586fb7ab263f90b4247f543e3ad920c0c3689 [10/22] guest id: optionally enforce the next-id range and uniqueness commit: 9d0d825d768bcdc276c0cedeb6075e32f0f70995 [11/22] guest id: add helper to check guest IDs against next-id enforcement commit: 5281096e9b33c7385c035c1c1d46dbe3980b54f8 [12/22] api: record VM ID as used on destruction and remote migration commit: f6c9b967ec0421762aa3e4e2e37d4e123ae510a7 [13/22] api: record CT ID as used on destruction and remote migration commit: aea09753f1cd224a6ee8f76bc2037ddaf8105b33 [14/22] ui: guest ID selector: rename exists flag to rejected commit: 347b52934adad4848daeafe6e32dba1fd80eaee2 [15/22] ui: guest ID selector: show the error returned by nextid commit: b3b3804b35af9b71d621cced7f5cd19f9d1111ef [16/22] fix #4369: api: optionally only suggest unique IDs commit: a1d6b80d1b62120a96b555fe0ebe6d6f40c58ad0 [17/22] ui: dc options: rename VMID to guest ID commit: d755a84c916792a479316900927bd28d90a2d357 [18/22] fix #4369: ui: dc options: add option for unique VM/CT IDs commit: 7d3b6526165d72dc824c95bd1bdc0d52e241fa3d [19/22] api: nextid: reject IDs forbidden by next-id enforcement commit: 0b2f7eeaecd67126b0390864d6f9c21fb736a7c4 [20/22] ui: dc options: add option to enforce next free guest ID settings commit: 22883363b7378f9eddb7fe3ba960dc33b7b0ea11 [21/22] pmxcfs: files: add virtual-guest/used-guest-ids commit: e42a3773cd4c94e5f6d902c916162c85a658201c [22/22] pvecm: next-id: document unique and enforce options commit: c8bfbf36d3d2b2978e663c786ec56200b4cb1c26