From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 852191FF0E1 for ; Mon, 16 Nov 2026 03:21:16 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 80947216D0; Mon, 16 Nov 2026 03:21:13 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, "Max R. Carrara" Subject: applied: [PATCH common/manager/proxmox-widget-toolkit/storage/storage-plugin-examples v5 00/19] GUI Support for Custom Storage Plugins Date: Mon, 16 Nov 2026 03:20:41 +0100 Message-ID: <179479559569.3545356.12588016086029581343.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261113203330.932813-1-m.carrara@proxmox.com> References: <20261113203330.932813-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794795668497 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.072 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: W2Y36J5ZG5UFFFHEFLEP5TLE2L3FKGQT X-Message-ID-Hash: W2Y36J5ZG5UFFFHEFLEP5TLE2L3FKGQT X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Alfonso Kuen , Thomas Ellmenreich , Jakob Klocker X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 13 Nov 2026 21:33:04 +0100, Max R. Carrara wrote: > GUI Support for Custom Storage Plugins - v5 > =========================================== > > This is another refresh based on the feedback on v4 and also some > off-list discussions. Some additional fixes and little things have also > been rolled in. > > [...] Applied, thanks! I folded a few small things in while applying, they are noted in the respective commits: - storage 1/9: the plugin list reported the 'origin' filter parameter as origin of every plugin until 4/9 fixed that, so it was undefined without a filter. - storage 3/9: a property in 'sensitive-properties' is now always reported as sensitive, also if its schema explicitly sets the keyword to 0. Its value is never returned, so the editor would otherwise delete it on an unrelated save. - typos and stale wording in some commit messages (the multiline "format", checking the Perl module path), a few wide-field xtypes that could not occur in the editor, and a new subject for the SSHFS patch. And some follow-ups on top: - storage: GET /storage and GET /storage/{storage} return 'content-dirs' as the string that the update call accepts. It was the parsed hash, which the generated editor showed and sent back as "[object Object]". - storage: a test for the metadata endpoints and an ApiChangeLog section for plugin authors. It also spells out that 'multiline' is only a hint for the editor, the section config still refuses line feeds, and that a property in 'sensitive-properties' cannot be required. - widget-toolkit: the base64 text area builds on the new text area instead of duplicating its submit handling. - manager: the summary of a storage shows the display name of the plugin too. - examples: the Borg plugin got 'multiline' for its SSH key properties, titles and a display name. [pve-common] applied to pve-common.git (master) [1/1] json schema: add multiline validation keyword https://git.proxmox.com/?p=pve-common.git;a=commitdiff;h=5f147108fb9e6bd9f386f20b745864996a51c8ae [pve-manager] applied to pve-manager.git (master) [1/5] api: sort modules and API method registrations https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=0cef7b9a19ee9b9312c93061a3f7d435b6e50a40 [2/5] ui: storage: remove entry of the removed DRBD plugin https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=6c26883a83dffc79a71de68e4cd5d85cdc333afb [3/5] api: add API routes 'plugins' and 'plugins/storage' https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=37d5cbd176b76d4fa198d9079847c71502402f26 [4/5] ui: storage view: display error when no editor for storage type exists https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=85332cfe6de6b9409a3ea3c2cf380b98de326fc5 [5/5] ui: storage: add basic UI integration for custom storage plugins https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=b3781b97ae0aad66b319e41b4918066e0fc4ed06 [proxmox-widget-toolkit] applied to proxmox-widget-toolkit.git (master) [1/3] form: introduce new 'proxmoxtextarea' field https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=c391882eeb229e549f8d034bf5002faf47473518 [2/3] utils: introduce helper function getFieldDefFromPropertySchema https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=940e056f6f390bd2ed50f597f78acaf87c17cb2d [3/3] acme: use helper to construct ExtJS fields from property schemas https://git.proxmox.com/?p=proxmox-widget-toolkit.git;a=commitdiff;h=3eca98e87c20001444f8b52618bb9a25c513ae1b [pve-storage] applied to pve-storage.git (master) [1/9] api: plugins/storage: add initial routes and endpoints https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=5f84cec88b4d27af06940c4ed5ef591d723b9e9e [2/9] api: plugins/storage/plugin: include schema in plugin metadata https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=d5ab3c5d5d7efa0556ba717238162555ec3eba14 [3/9] api: plugins/storage/plugin: handle sensitive properties in schema https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=523bda7742b4ec4c8e621c4a901e8c3be255ac17 [4/9] api: plugins/storage/plugin: factor plugin metadata code into helper https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=f8d0f1c1a472e7a383998d41f863d7509bd49f9d [5/9] api: plugins/storage/plugin: add plugins' 'content' to their metadata https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=1d287922800590aab173bbc940877c508b2207fc [6/9] all plugins: add 'title' to properties, adapt 'description's https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=4d2f5a31fd749f4e24632083bc7dd3766c73d2db [7/9] all plugins, api: mark certain properties as advanced in plugindata() https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=0fe12a447591997902c04f8a04e17dfceb7fe1bd [8/9] all plugins, api: mark certain properties as hidden in plugindata() https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=2d2a7031e7b1c273c70a05170f1908aef95abcba [9/9] api: plugins/storage/plugin: allow plugins to have display names https://git.proxmox.com/?p=pve-storage.git;a=commitdiff;h=83e45f5964f5b15e75563103d2b787507ba2eff2 [pve-storage-plugin-examples] applied to pve-storage-plugin-examples.git (master) [1/1] sshfs: Update SSHFS plugin https://git.proxmox.com/?p=pve-storage-plugin-examples.git;a=commitdiff;h=861bd66ca7daea21da92870e5301f28a03c1d71f