From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 86A7D1FF0A8 for ; Sat, 14 Nov 2026 22:33:15 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CF92F21536; Sat, 14 Nov 2026 22:33:10 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Hannes Laimer Subject: applied: [PATCH pve-network] config: release the addresses of a NIC removed from a running container Date: Sat, 14 Nov 2026 22:33:00 +0100 Message-ID: <179469198018.2480055.16504677006494155269.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261112104059.2377096-1-h.laimer@proxmox.com> References: <20261112104059.2377096-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794691988103 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.232 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RMDW3B7C2MRZMAJBXGYXB2OHXYYC2WBG X-Message-ID-Hash: RMDW3B7C2MRZMAJBXGYXB2OHXYYC2WBG X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 12 Nov 2026 11:40:59 +0100, Hannes Laimer wrote: > Without `$class->..` the passed options ended up as the first > argument, and the `undef` check on the second argument, `!$data`, > ended up returning an empty hash. So the NIC's addresses were never > released in the IPAM, and the DHCP client of a host-managed NIC was > not stopped. Destroying the container did not release them either, > since the NIC is gone from the config by then. > > [...] Applied, thanks! [1/1] config: release the addresses of a NIC removed from a running container commit: b91881f0cc5bcf533dfb153c4ffa0f282101d1a2