From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D6B241FF0EC for ; Sat, 07 Nov 2026 23:09:53 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7FF8F215C2; Sat, 07 Nov 2026 23:09:40 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Christoph Heiss Subject: applied: [PATCH installer v5 00/23] fix #2164: add bond and vlan setup across all installers Date: Sat, 7 Nov 2026 23:07:48 +0100 Message-ID: <179408895108.3020734.14149092579399794245.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261106131058.804870-1-c.heiss@proxmox.com> References: <20261106131058.804870-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794089371043 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.152 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HEHB4SXCIW4GY2EUUCJJBRSSXGXNPXPX X-Message-ID-Hash: HEHB4SXCIW4GY2EUUCJJBRSSXGXNPXPX X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 06 Nov 2026 14:10:29 +0100, Christoph Heiss wrote: > Fixes #2164 [0] by adding the possibility to set up a bond and a VLAN tag for > the management interface during the installation, for all of GUI, TUI and > auto-installer. > > For the GUI and TUI, the current name pinning dialog is converted into a > full-fledged advanced network options dialog, in the same vein as with > the bootdisk options. > > [...] Applied, many thanks! I folded a few changes into your patches, each noted in a [TL: ...] block of the commit message. The main ones: - generator: name the VLAN interface 'vlan' with an explicit raw device, as '.' can exceed the interface name length limit with long predictable names. Resolve bond members to physical links, the first by name for a MAC address shared by several, and keep the generated configuration unchanged for setups without a bond or VLAN. - auto-installer: pass the bond options with the keys and lowercase MAC addresses the low-level installer expects, reject unknown members and DHCP leases not received on a member, also set up the bond with the 'from-answer' source, and mark all members as management interfaces in the post-hook data (schema 1.3). - GUI and TUI: read and check the options only while bonding or the VLAN is enabled, take the VLAN tag from a plain entry, as the spin button silently replaced invalid tags by the nearest valid one, show 802.3ad as LACP and label members with their pinned names. Patches 22 and 23 are folded into 10 and 18. - the TUI and auto-installer leave out links without an Ethernet MAC address, like InfiniBand ones, which the `MacAddress` type cannot hold. - structs are adapted in the commits changing them, so that every commit builds, and the series requires proxmox-installer-types 0.3.1. On top, as separate commits: - GUI: keep the advanced options dialog open if it is closed via the window with invalid input, and modal until it is closed. - note the balance-alb and balance-tlb modes as unsuitable with a bridge, in all installers. - support a tagged network in the installation environment, via the 'proxmox-vlan' kernel parameter or 'prepare-iso --vlan-id', and use its tag for the management network by default. - reject pinned names of the form bondN, vlanN and vmbrN. - select bond members by udev properties in the answer file. - label bond members with the pinned names as entered in the dialog. - TUI: avoid an underflow in the tabbed view with narrow tab contents. [01/23] install: run make tidy commit: e2644833648f89de89b95345b0858cdc3880eda9 [02/23] tree-wide: use `MacAddress` type instead of string for MAC addresses commit: 6fe01041152e5ceb27cfcce588a08d0ae18b8c26 [03/23] install: factor out ifupdown2 config generation into own subroutine commit: ab268db2123c476069ac2014ab8a690ecf136f79 [04/23] install: do not rely on interface name map to be fully populated commit: 48acddf76734b3d3282d88a85082360eedb0b64c [05/23] install: config: add option for setting up bond on management interface commit: 7855417047658554183d941a23e2cf4f50701ade [06/23] install: config: add option for setting up vlan on management interface commit: 61c0c6f361ce86468aa24c6afa2a373b780c3662 [07/23] install: network: set up management bond if requested commit: 0543d1e123d52142929906e025f59651bd9a5f40 [08/23] install: network: set up vlan on management interface if requested commit: 6fec9d7fd40fa77fef3fa84d8b6a055f30dcf0bf [09/23] gui: network: factor out name pinning into advanced options dialog commit: 210ec2c7a6760610c4ea0d38bf8f52bb0db62c74 [10/23] gui: network: add bond setup options to advanced options dialog commit: 9855583d1be34897ba698739b5e4f767a46296c2 [11/23] gui: network: add vlan setup options to advanced network dialog commit: 0d38555bffc8eb07ccec38336fa10e0ffe0e983c [12/23] auto: pass through management network bond options to low-level installer commit: cf6717a51358b7e8544daf15f2a114e955e326c3 [13/23] auto: pass through management network vlan options to low-level installer commit: 8c0b5f5ec25de4608e8b2e3961b936a1d15b0f02 [14/23] tui: drop long obsolete comment about logo formatting commit: 2cd910fc3511a715d362874977eb996c500fe4e4 [15/23] tui: views: add widget for displaying a group of checkboxes commit: f0ac4c5d9f284fdc8a00abd63b0ce8478e509324 [16/23] tui: network: factor out name pinning into advanced options dialog commit: 7afba62dcf3e1930504c8168fd97b151c27250ba [17/23] tui: network: match form label style when enabling/disabling elements commit: 854425f8e0327b56bc38919b49259fe8e939e4bb [18/23] tui: network: add bond setup options to advanced network dialog commit: b492fc69543c70a5fba44aa31dec28f5586eaa0f [19/23] tui: network: add vlan setup options to advanced network dialog commit: 065c9ba43454d38d8810d1019230a33c2d5624c5 [20/23] gui: network: split advanced options dialog into tabs commit: 3e15d0376b44d86f34edd10fd8421b3ab4091731 [21/23] tui: network: split advanced options dialog into tabs commit: 6d0b559ecbd67d1a6073b2d904bf7ef493a15ecf [22/23] gui: network: list bond member candidates sharing a MAC address once (folded into 10/23) [23/23] tui: network: list bond member candidates sharing a MAC address once (folded into 18/23)