From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DE8581FF0DF for ; Thu, 05 Nov 2026 14:32:34 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8638721667; Thu, 05 Nov 2026 14:32:26 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com, Michal Fox Subject: applied: [PATCH proxmox-acme] fix #7155: proxmox-acme: support upper-hex mode of _url_encode Date: Thu, 5 Nov 2026 14:31:00 +0100 Message-ID: <179388543087.1046105.13888509223557962367.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261004125925.7-1-me@dualfroz.com> References: <20261004125925.7-1-me@dualfroz.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793885541654 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.598 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WHWKQIGSVXMGCBY7KV67YYUJZWUSNYHW X-Message-ID-Hash: WHWKQIGSVXMGCBY7KV67YYUJZWUSNYHW X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sun, 04 Oct 2026 12:59:25 +0000, Michal Fox wrote: > The _url_encode function of acme.sh takes an optional 'upper-hex' > argument, which makes it output the percent-encoded characters with > upper-case hex digits. Our copy of the function in proxmox-acme lacks > it and always outputs lower-case hex. > > The Aliyun DNS plugin of the bundled acme.sh version uses this argument > for the signature of its API requests, as the Aliyun API requires > upper-case hex there. So the signature never matched, and adding the > TXT record always failed with "SignatureDoesNotMatch". > > [...] Applied, thanks! [1/1] fix #7155: proxmox-acme: support upper-hex mode of _url_encode commit: 8281c38197c1fc8b18f92b73760beb8a4de3936b Best regards, -- Fabian Grünbichler