From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 882141FF0BC for ; Thu, 29 Oct 2026 14:53:46 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 20618214ED; Thu, 29 Oct 2026 14:53:32 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Lukas Sichert Subject: applied: [PATCH container] api: template: allow creating template from ct with disk on LVM Date: Thu, 29 Oct 2026 13:35:38 +0100 Message-ID: <179327733496.465877.256937661032406944.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260312182714.108583-1-l.sichert@proxmox.com> References: <20260312182714.108583-1-l.sichert@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793277345376 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.441 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ROPCZSMHSIGTUBESH76SMFBNNURHESB7 X-Message-ID-Hash: ROPCZSMHSIGTUBESH76SMFBNNURHESB7 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 12 Mar 2026 19:27:05 +0100, Lukas Sichert wrote: > Currently, in the UI, one can create a template from a VM with a disk on > LVM storage, but not from a container. This is because the LVM plugin > does not have the functionality to create base images from disks > implemented. While the system simply skips this function for VMs, it > throws an error and aborts for LXC containers. > > To allow converting to a template, skip the volumes where the required > functionality is not present by exiting early instead of aborting. > > [...] Applied, thanks! [1/1] api: template: allow creating template from ct with disk on LVM commit: fa9cd3e16af667cc09592f30705a472a38ae72b9