From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 3FD7A1FF0B3 for ; Wed, 28 Oct 2026 18:28:40 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 52D1921684; Wed, 28 Oct 2026 18:28:09 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Kefu Chai Subject: applied: [PATCH manager] fix #8195: api: ceph: mds: lock ceph.conf when changing MDS sections Date: Wed, 28 Oct 2026 18:27:54 +0100 Message-ID: <179320847186.1870597.11021651003058091341.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261026075604.1101150-1-k.chai@proxmox.com> References: <20261026075604.1101150-1-k.chai@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793208483092 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.468 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EKG7NMOJTFE7J73ONLGJ52JNHZH6QUOT X-Message-ID-Hash: EKG7NMOJTFE7J73ONLGJ52JNHZH6QUOT X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 26 Oct 2026 15:56:04 +0800, Kefu Chai wrote: > createmds and destroymds read, modify and write ceph.conf without the > cfs lock, so concurrent tasks can lose each other's changes. E.g. > destroying two MDS in parallel can leave one section behind, blocking > that ID from being reused. > > Take the lock for each update, as the monitor code does. The createmds > error path runs after the lock was released, so it only removes the > section if it still names this node. > > [...] Applied, thanks! [1/1] fix #8195: api: ceph: mds: lock ceph.conf when changing MDS sections https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=6acb938bd9b1d43c94b2396c540ef27c1634a19c