From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E779A1FF0AA for ; Tue, 20 Oct 2026 20:51:46 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 69DA6215FB; Tue, 20 Oct 2026 20:51:42 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Stoiko Ivanov Subject: applied: [RFC kernel-helper] proxmox-boot: find root dev for grub default entry as update-grub does Date: Tue, 20 Oct 2026 20:50:43 +0200 Message-ID: <179252224008.23374.11078416506300426282.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261012201501.977578-1-s.ivanov@proxmox.com> References: <20261012201501.977578-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792522296196 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.474 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SJY3KGYI23655ZJRWXS65NCUDQRDTCXZ X-Message-ID-Hash: SJY3KGYI23655ZJRWXS65NCUDQRDTCXZ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 12 Oct 2026 22:11:08 +0200, Stoiko Ivanov wrote: > Reading the ID that update-grub/grub-mkconfig uses for generating > unique ids for boot-entries from the existing grub.cfg breaks if the > following update-grub call changes the device id, effectively > rendering the pin setting useless. > > Reported in our community-forum in context of renamed /dev/nvmeXnYpZ: > https://forum.proxmox.com/threads/186882/ > > [...] Applied with some smaller fixups folded in (see commit message trailer), thanks! [1/1] proxmox-boot: find root dev for grub default entry as update-grub does commit: dd37f595127f9c48b7140100dae8f794a026a14b