From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 57AED1FF0AA for ; Tue, 20 Oct 2026 17:25:16 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 06EEC2159F; Tue, 20 Oct 2026 17:25:16 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH qemu-server v3 8/8] hotplug: name the missing bridge in the error message Date: Tue, 20 Oct 2026 17:23:23 +0200 Message-ID: <179250968632.184948.4524536826954910128.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261007142145.984970-9-d.csapak@proxmox.com> References: <20261007142145.984970-9-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792509886061 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.349 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: T4DXYUZ4PDOQZM4QFXS5KG32KHW3LSTU X-Message-ID-Hash: T4DXYUZ4PDOQZM4QFXS5KG32KHW3LSTU X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 07 Oct 2026 16:17:52 +0200, Dominik Csapak wrote: > Recently it was uncovered that hotplugging scsiX >= 14 does not work > in all situations. Inspired by this, this attempts to add some hotplug > regression tests by simulating the qmp/hmp environment, recording the > calls and testing against some invariants. > > This uncovered three additional bugs in the hotplug code: > * hotplugging a tablet device into an aarch64 vm fails > * hot unplugging a tablet device into an aarch64 vm left over the keyboard > * failure to hotplug a disk with iothreds leaves the iothread behind > > [...] Applied this one already, thanks! [8/8] hotplug: name the missing bridge in the error message commit: 59cf25ad66fd35741855aa3de7ac24bc9835eb02