From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 863AA1FF0B7 for ; Fri, 16 Oct 2026 01:38:07 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4F89621553; Fri, 16 Oct 2026 01:38:00 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Fiona Ebner Subject: applied: (subset) [PATCH-SERIES qemu-server 0/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling Date: Fri, 16 Oct 2026 01:37:45 +0200 Message-ID: <179210744271.3827773.904461787424534644.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260925122646.139215-1-f.ebner@proxmox.com> References: <20260925122646.139215-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792107476233 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.496 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VEAWT36BOU4JMXANHWO6AU263UG3J46K X-Message-ID-Hash: VEAWT36BOU4JMXANHWO6AU263UG3J46K X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 25 Sep 2026 14:26:24 +0200, Fiona Ebner wrote: > When removing a volume chain snapshot, the blockdev properties are > re-generated in blockdev_{commit,replace,stream}() to operate upon. > This must happen with the current drive information, not the one from > the time the snapshot was taken. > > A similar bug was present before volume chain snapshots existed, and > fixed by commit c6058683 ("fix #2258: select correct device when > removing drive snapshot via QEMU"). This is where the handling for > $attached_deviceid comes from. With snapshot-as-volume-chain, this > needs to be extended to the full drive information, not just the > device ID. > > [...] Applied, thanks! [1/7] volume snapshot (delete): avoid using deprecated check_running() helper https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=5170164706fb1460968a2232babbdd910685cbeb [2/7] volume snapshot delete: move getting attached device ID to caller https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=7552590ed754e587aa67361d85b60717689dd678 [3/7] fix #8071: volume snapshot delete: use current drive information to fix SAVC handling https://git.proxmox.com/?p=qemu-server.git;a=commitdiff;h=30b0e83b2bbba8be6764b0e9f4c61de29574012b