From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 835CE1FF0BC for ; Thu, 15 Oct 2026 14:46:19 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C6BCB2168D; Thu, 15 Oct 2026 14:45:39 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH pve-firewall v2 06/12] fix #5759: firewall: restore from dumped config before network-pre From: Stefan Hanreich To: Arthur Bied-Charreton In-Reply-To: <20261001122625.348730-7-a.bied-charreton@proxmox.com> References: <20261001122625.348730-1-a.bied-charreton@proxmox.com> <20261001122625.348730-7-a.bied-charreton@proxmox.com> Date: Thu, 15 Oct 2026 14:45:23 +0200 Message-Id: <179206832307.200960.5663862445501998810.b4-review@b4> X-Mailer: b4 0.16-dev-fbf84 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792068331245 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.490 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3GUAZT5B4KUTJVLICDRADNQ27JIYGBUV X-Message-ID-Hash: 3GUAZT5B4KUTJVLICDRADNQ27JIYGBUV X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > pve-firewall depends on pve-cluster for its config, pve-cluster > depends on corosync, which itself depends on network-online. This > creates a window at boot where the network is up with no protection. > > To address this, add a simple oneshot service depending on > network-pre [0] that applies the last remembered rules to bridge the gap > until the configured firewall daemon takes over. > > [0] https://systemd.io/NETWORK_ONLINE/ > > Link: https://bugzilla.proxmox.com/show_bug.cgi?id=5759 > Signed-off-by: Arthur Bied-Charreton > Reviewed-by: Thomas Ellmenreich > Tested-by: Thomas Ellmenreich > > diff --git a/debian/pve-firewall-pre-network.service b/debian/pve-firewall-pre-network.service > new file mode 100644 > index 0000000..e1127e4 > --- /dev/null > +++ b/debian/pve-firewall-pre-network.service > @@ -0,0 +1,16 @@ > +[Unit] > +Description=Proxmox VE Pre-Network iptables Firewall > +Wants=network-pre.target > +Before=network-pre.target shutdown.target > +Conflicts=shutdown.target > +DefaultDependencies=no > +After=local-fs.target > + > +[Service] > +Type=oneshot > +ExecStart=/usr/sbin/pve-firewall restore > +RemainAfterExit=true > +Environment=PVE_LOG=info Is this potentially a leftover from the nftables service? Afaik there's no such envvar for pve-firewall. -- Stefan Hanreich