From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id AC6A71FF0BC for ; Thu, 15 Oct 2026 14:45:37 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 53B79214DD; Thu, 15 Oct 2026 14:45:36 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH pve-firewall v2 02/12] firewall: config: sort OPTIONS when serializing From: Stefan Hanreich To: Arthur Bied-Charreton In-Reply-To: <20261001122625.348730-3-a.bied-charreton@proxmox.com> References: <20261001122625.348730-1-a.bied-charreton@proxmox.com> <20261001122625.348730-3-a.bied-charreton@proxmox.com> Date: Thu, 15 Oct 2026 14:45:23 +0200 Message-Id: <179206832307.200960.10876962220083340464.b4-review@b4> X-Mailer: b4 0.16-dev-fbf84 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792068331020 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.522 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TLLH7MX77AZTV4X4WXS6NDY3LWSF2D3S X-Message-ID-Hash: TLLH7MX77AZTV4X4WXS6NDY3LWSF2D3S X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 01 Oct 2026 14:26:15 +0200, Arthur Bied-Charreton wrote: > Until now, firewall config serialization was iterating over the options > hash without sorting the keys, making the output non-deterministic. > > Iterate over the sorted keys instead in format_options. Reviewed-by: Stefan Hanreich -- Stefan Hanreich