From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 82F341FF0B3 for ; Wed, 14 Oct 2026 11:08:48 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 02BAD2145A; Wed, 14 Oct 2026 11:08:46 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Maximiliano Sandoval Subject: applied: [PATCH proxmox-i18n v3 00/12] Makefile simplifications and improvements Date: Tue, 13 Oct 2026 12:49:08 +0200 Message-ID: <179188828728.3746353.2769337013152384195.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260727095957.223209-1-m.sandoval@proxmox.com> References: <20260727095957.223209-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791968922077 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address DATE_IN_PAST_12_24 0.804 Date: is 12 to 24 hours before Received: date DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZLQN66JJWMFU6KBZC6NBT3HR6MRLDSJQ X-Message-ID-Hash: ZLQN66JJWMFU6KBZC6NBT3HR6MRLDSJQ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 27 Jul 2026 11:59:43 +0200, Maximiliano Sandoval wrote: > The main difference in behavior is that we add --previous to the msgmerge > command used to update the PO files. This can add some extra information to > translations, which can make it easier to determine whether the previous > translation is still valid or what kind of modifications it needs. > > See individual commits and their notes. > > [...] Applied, thanks! With some changes folded in, see added trailers in commit, but in essence: - 01: dropped the msgmerge call instead, as msgfmt never read its output and merging would not change the catalog anyway; 02 lost its catalog-%.mo hunk accordingly - 08: added the missing meson link - 09: switched to diffing LINGUAS against make's sorted PO file list, which is locale independent and names the offending entries - 10: switched to sorting in the C locale, matching check-linguas - 11, 12: dropped .PHONY for the pattern targets, .PHONY does not take patterns - some commit message rewording and rewrapping Also added two fixes: - make: yew catalogs: fail on msgmerge errors (416e84a) - make: init-%.po: pass language code as locale to msginit (0d3e5e5), it passed messages.pot, so new PO files failed 'make check' [01/12] make: catalog-%.mo: explicitly set template file commit: 0f434c5de01b85e3c4b8853deeb1317d0e1b6daf [02/12] make: simplify msgmerge commands commit: 6e83f0c26f5d8683d914c65175d0b75ea047f964 [03/12] make: clean: remove *.mo files commit: ad57c55dbe2b45dfefcd6c33461f3b269e545bb4 [04/12] make: use long options for msgmerge and msginit commit: 1f1da3194c9e351e0e6c2a8b9ee1a8136d810153 [05/12] make: do_update: add --update for msgmerge commit: 3b3e95a3f84ca93c76cbbfcbc856377abbef0688 [06/12] make: do_update: add --previous flag to msgmerge commit: 18d4857a154ab020e09b51e8d5d45449e787e0dd [07/12] gitignore: remove proxmox-datacenter-manager.pot commit: 8ab58721347f07b9187629c34c6ab43702e747b1 [08/12] make: move linguas to a file commit: e6258e3f90bf8438890e145de627b2a06b893de0 [09/12] make: add check-linguas target commit: 47e09ac2a0348f9c3cc7128ecc37a3015b2175d6 [10/12] make: init-%.po: add language to linguas commit: a3991f890095363ae215176a2eca87cfecbfa561 [11/12] make: add targets to update specific PO files commit: 738ab96e7ed2135c721f33b9a65aa19dcab7db56 [12/12] make: rename check-% target to check-%.po commit: 57958aad2ee4fb03bc632b7e9da2e679360d1759