From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 117F81FF09B for ; Mon, 12 Oct 2026 18:35:34 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BB62A213E2; Mon, 12 Oct 2026 18:35:31 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Elias Huhsovitz Subject: applied: [PATCH manager v2] fix #8093: pvestatd: remove stale lxc console reaper Date: Mon, 12 Oct 2026 18:35:20 +0200 Message-ID: <179182290815.1213264.5494450283477967181.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261009123819.136563-1-e.huhsovitz@proxmox.com> References: <20261009123819.136563-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1791822926856 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.588 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IDKO4IQQBGH377ARNHC34PY4NRYC4S2V X-Message-ID-Hash: IDKO4IQQBGH377ARNHC34PY4NRYC4S2V X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 09 Oct 2026 14:38:19 +0200, Elias Huhsovitz wrote: > remove_stale_lxc_consoles() calls PVE::LXC::vmstatus() every cycle, > which runs `lxc-info` once per running container. Since > update_lxc_status() already calls vmstatus() in the same cycle, this > doubles the overhead of running `lxc-info`. Thus, this overhead is > scaling linearly with the number of containers. > > Under normal operation, lxc-console and dtach exit automatically when > the container stops. The reaper only fires in broken system states, such > as deleting the container config file while the container is still > running. A continuous polling reaper is not an appropriate mechanism for > these situations. > > [...] Applied, thanks! [1/1] fix #8093: pvestatd: remove stale lxc console reaper https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=888c136dd303f41d7950a5c9c7381a6f14cea33b