From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 68A841FF0C0
	for <inbox@lore.proxmox.com>; Wed, 30 Sep 2026 12:28:41 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id B611D21692;
	Wed, 30 Sep 2026 12:28:25 +0200 (CEST)
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Michal Fox <me@dualfroz.com>
Subject: applied: [PATCH manager] fix #5608: ui: resource mappings: validate
 the name like the API does
Date: Wed, 30 Sep 2026 12:27:53 +0200
Message-ID: <179076404143.1629239.10192032693270079310.b4-ty@b4>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260929141313.2873638-1-me@dualfroz.com>
References: <20260929141313.2873638-1-me@dualfroz.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.424 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: AEVPM3K4Q7J3JJMERSNVFOIEN4DCG4RJ
X-Message-ID-Hash: AEVPM3K4Q7J3JJMERSNVFOIEN4DCG4RJ
X-MailFrom: d.csapak@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Tue, 29 Sep 2026 16:13:13 +0200, Michal Fox wrote:
> The API only accepts resource mapping IDs in the 'pve-configid' format,
> but the name field of the PCI, USB and directory mapping windows takes
> any value. A name like 'gpu@node1' is thus only rejected after
> submitting, with a generic "invalid configuration ID" error that does
> not tell which characters are allowed.
> 
> Use the existing 'ConfigId' vtype, so the field is marked invalid right
> away and its tooltip lists the allowed characters.
> 
> [...]

Applied, thanks!

[1/1] fix #5608: ui: resource mappings: validate the name like the API does
      commit: 55c76c27465287eccef01d16f26ff1d6fe37569a