From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id B868A1FF0AA
	for <inbox@lore.proxmox.com>; Tue, 22 Sep 2026 15:26:36 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 3AE06214C1;
	Tue, 22 Sep 2026 15:26:34 +0200 (CEST)
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
	=?UTF-8?q?Michael=20K=C3=B6ppl?= <m.koeppl@proxmox.com>
Subject: applied: [PATCH qemu-server 1/1] fix #8030: snapshot: avoid orphaned
 vmstate volume on failure
Date: Tue, 22 Sep 2026 15:26:14 +0200
Message-ID: <179008357127.384092.4717454414015502114.b4-ty@proxmox.com>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260914140547.615346-1-m.koeppl@proxmox.com>
References: <20260914140547.615346-1-m.koeppl@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1790083589466
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.540 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: R7HPVOL4YBVA3LWBLBRTMG47F4EBAPI5
X-Message-ID-Hash: R7HPVOL4YBVA3LWBLBRTMG47F4EBAPI5
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Mon, 14 Sep 2026 16:05:47 +0200, Michael Köppl wrote:
> The state volume was allocated before the running instance was queried
> for its machine type, CPU argument and network MTUs. Those queries can
> fail (e.g. the 'query-machines' QMP command, which can run into a
> timeout while QEMU's is busy [0]).
> 
> The helper is called from __snapshot_prepare() before write_config(), so
> the config never records the snapshot, snapshot_create() dies before it
> gets to its cleanup path. Such a failure leaves behind the just
> allocated volume.
> 
> [...]

Applied, thanks!

[1/1] fix #8030: snapshot: avoid orphaned vmstate volume on failure
      commit: 1db755c9bb3233d92770b8d9dcd8f3792380daec