From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D657B1FF09C for ; Mon, 21 Sep 2026 13:20:09 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 59E91214A3; Mon, 21 Sep 2026 13:20:09 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Nicolas Frey Subject: applied: [PATCH qemu-server 0/3] fix #7801: warn about problematic VirtIO ISOs Date: Mon, 21 Sep 2026 13:19:22 +0200 Message-ID: <178998932620.132079.13675936535114565819.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260915143237.1033142-1-n.frey@proxmox.com> References: <20260915143237.1033142-1-n.frey@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789989599973 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.552 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: CY27ZGW5SYXT45T5NSMUYRCFQAFELRMV X-Message-ID-Hash: CY27ZGW5SYXT45T5NSMUYRCFQAFELRMV X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 15 Sep 2026 16:32:34 +0200, Nicolas Frey wrote: > This series fixes #7801 by implementing backend-only checks for VirtIO > ISOs with known issues. When a user starts, creates, or updates a VM, > the system scans for problematic VirtIO filenames and logs a warning in > the task log if a known issue is detected. > > This approach supersedes the earlier UI patches [0], following feedback > to implement the check in the backend. Since the backend check already > alerts users via task log warnings (an equally effective and less intrusive > solution) the separate API call and UI patches became unnecessary. > > [...] Applied, thanks! In commit 2/3, I changed the calls for parse_drive() and drive_is_cdrom() to not call the imported versions via QemuServer, but the ones from the Drive module directly. I also pushed an UI follow-up to make the warnings visible upon edit already: https://lore.proxmox.com/pve-devel/20260921111843.133598-1-f.ebner@proxmox.com/T/ [1/3] drive: add helper to detect VirtIO driver ISOs with known issues commit: 881fd37d17157982765c6c8fa3265eff57f84de9 [2/3] partially fix #7801: api: warn about problematic VirtIO driver ISOs commit: 80ae2f0a354ad164269a1987fc483f492d28f022 [3/3] partially fix #7801: vm start: warn about problematic VirtIO ISOs commit: f34b8f9f2a9eb89b237561ed1aff7a76a7e06774