From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0F0F71FF13F for ; Fri, 18 Sep 2026 10:31:09 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 11D02214A8; Fri, 18 Sep 2026 10:31:07 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Jakob Klocker Subject: applied: [PATCH storage v3 0/2] fix #7598: qemu-img: increase timeout for image resize Date: Fri, 18 Sep 2026 10:29:57 +0200 Message-ID: <178972019162.20962.13034324928353555188.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260811073740.100398-1-j.klocker@proxmox.com> References: <20260811073740.100398-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1789720258028 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.629 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5VFZJXCXWKO5TXTKYQFSJAEV2DBEEQO7 X-Message-ID-Hash: 5VFZJXCXWKO5TXTKYQFSJAEV2DBEEQO7 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 11 Aug 2026 09:37:38 +0200, Jakob Klocker wrote: > Image resizing currently has a timeout of 10 seconds, which can fail > on slow disks and leave the VM in a state where the disk is updated, > but the VM config isn't. > > Since there is no deterministic way to check, with less overhead, if > this is the case, increasing the timeout is the most pragmatic > solution. The resize is only called in a worker context anyway, > therefore this patch series mirrors the ZFS timeout: it increases > the timeout in a worker context to 1 hour; as a fallback for a > non-worker context the timeout stays 10 seconds. > > [...] Applied, thanks! In the second patch, I made two small changes: * style: avoid combining ternary conditional operator and post-if * wrap doc comment to avoid line longer than 100 characters [1/2] qemu-img: drop redundant timeout argument at resize call commit: 1b930a64a67ba21b7e3f4d3cfb578f240c71b661 [2/2] fix #7598: qemu-img: increase timeout for image resizing in worker context commit: e27a8036f5dc9d2d09e427b055264d97725566d7