From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 2A5EF1FF0B2 for ; Tue, 08 Sep 2026 16:22:10 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7F04E215A3; Tue, 08 Sep 2026 16:22:08 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Erik Fastermann Subject: partially-applied: [PATCH qemu v2 0/9] savevm-async: fix stuck paused vm after snapshot Date: Tue, 8 Sep 2026 16:21:52 +0200 Message-ID: <178887727784.249651.2956102114551397886.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260907094744.131193-1-e.fastermann@proxmox.com> References: <20260907094744.131193-1-e.fastermann@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788877312268 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.584 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZVPLYZRS6APUFCLMBQRC6WWWHH74YFH5 X-Message-ID-Hash: ZVPLYZRS6APUFCLMBQRC6WWWHH74YFH5 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 07 Sep 2026 11:47:34 +0200, Erik Fastermann wrote: > Snapshotting a paused VM left it in finish-migrate, where it stayed > until the VM was restarted. Fix this by storing the run state instead > and put it back, similar to migration_iteration_finish(). > > While working on that, I noticed some memory leaks and other issues, > which I found by using sanitizer tools like ASAN and reading the code > and docs. > > [...] Applied the first five patches, thanks! [1/9] d/patches: normalize header of pbs-restore no-cache patch commit: 7498b1bd7b71da1465631267620400b541d1de15 [2/9] pbs-restore: keep callback data on the stack commit: 10fd013483270154354657766e6645ca3e63af24 [3/9] migration/qemu-file: allocate buffer with g_malloc commit: 45d5a170a7c8628b1c743417b7e3d2a65a67033f [4/9] migration/pbs-state: check allocation of incoming state buffer commit: b6f2adbcea48c6b13613d638fc45643d4181471e [5/9] savevm-async: drop QIOChannel reference commit: 513917f9a745c641c6a783d35dd340beb469b785