From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id BD3C01FF0AE for ; Tue, 01 Sep 2026 14:47:04 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F3FB4214ED; Tue, 01 Sep 2026 14:47:03 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Dominik Csapak Subject: applied: [PATCH qemu-server] qemu: viommu: small variable code cleanup Date: Tue, 1 Sep 2026 14:46:54 +0200 Message-ID: <178826676890.166612.74485394150663090.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260831112543.2552200-1-d.csapak@proxmox.com> References: <20260831112543.2552200-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788266817720 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.773 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: C4LQSOVROR247OLFU7TSRJWK2TEBXSAT X-Message-ID-Hash: C4LQSOVROR247OLFU7TSRJWK2TEBXSAT X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 31 Aug 2026 13:25:37 +0200, Dominik Csapak wrote: > Reusing a variable the way done here reads not very nice and is easily > missable and possibly misunderstood. Instead use a dedicated variable > for the aw-bits additional and directly use that when pushing the > devices to the list. > > No functionality change intended. > > [...] Applied, thanks! I changed the commit title to be a bit clearer and avoid the superfluous 'qemu' prefix. [1/1] code cleanup: cfg2cmd: viommu: avoid unintuitive variable reuse commit: 9cba97b4f2d9244ea40ddac5130bc4d147bb1dc3