From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id B9C571FF0E2 for ; Thu, 30 Jul 2026 12:23:50 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9CC01214AC; Thu, 30 Jul 2026 12:23:46 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH perlmod v2 5/5] perlmod, macro: add #[hash] parameter attribute From: Wolfgang Bumiller To: "Max R. Carrara" In-Reply-To: <20260724144914.658730-6-m.carrara@proxmox.com> References: <20260724144914.658730-1-m.carrara@proxmox.com> <20260724144914.658730-6-m.carrara@proxmox.com> Date: Thu, 30 Jul 2026 12:23:39 +0200 Message-Id: <178540701947.33538.7866258952357724815.b4-review@b4> X-Mailer: b4 0.15.2 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785407012679 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.175 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: H7NL7ZO3AK7OHA4GD2RAC75ME2RCI7LP X-Message-ID-Hash: H7NL7ZO3AK7OHA4GD2RAC75ME2RCI7LP X-MailFrom: w.bumiller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 24 Jul 2026 16:49:07 +0200, Max R. Carrara wrote: > Like `#[list]`, `#[hash]` allows us to support subs for which any > number of additional key-value pairs may be passed, which is the same > as having an `;%` at the end of the Perl prototype. > > The `ParamsIter` type is added as a helper for pairwise iteration that > makes use of the fact that `ffi::StackIter` is now an > `ExactSizeIterator`, returning an error if the number of values on the > stack is odd on creation. It is then directly passed on to > serde's `MapDeserializer`, mirroring how `#[list]` works with > `SeqDeserializer`. > > [...] Acked-by: Wolfgang Bumiller --