From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id A9BBF1FF146
	for <inbox@lore.proxmox.com>; Tue, 07 Jul 2026 15:52:28 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id E13162143C;
	Tue, 07 Jul 2026 15:52:27 +0200 (CEST)
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: applied: [PATCH qemu-server] disk clone: warn when fallback is used
 instead of requested format
Date: Tue,  7 Jul 2026 15:51:34 +0200
Message-ID: <178343216235.112583.1418097852256524907.b4-ty@proxmox.com>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20260618125103.1784856-1-m.sandoval@proxmox.com>
References: <20260618125103.1784856-1-m.sandoval@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1783432337467
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.032 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 7SLYPYNVPOAEYOM4JHCHTIPNHL6EP5IE
X-Message-ID-Hash: 7SLYPYNVPOAEYOM4JHCHTIPNHL6EP5IE
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Thu, 18 Jun 2026 14:50:56 +0200, Maximiliano Sandoval wrote:
> We already print the same warning when importing. See f6039cedf for more
> details.

Applied, thanks! It was not tidy and I switched to using regular if
instead of post-if, since tidy would make it a multi-line post-if. And
I added the storage ID to the warning message. Also made a follow-up
extending the description of the format parameter for the clone and
move disk API endpoints.

[1/1] disk clone: warn when fallback is used instead of requested format
      commit: 913aec32f5f4b9ad18212a7c8f75657ed14c39be