From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 039D71FF13C for ; Thu, 11 Jun 2026 18:01:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6403C115FF; Thu, 11 Jun 2026 18:01:05 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH pve-network 1/1] api2: evpn status: properly handle nodes field of evpn zones From: Gabriel Goller To: Stefan Hanreich In-Reply-To: <20260528133947.309145-1-s.hanreich@proxmox.com> References: <20260528133947.309145-1-s.hanreich@proxmox.com> Date: Thu, 11 Jun 2026 18:00:24 +0200 Message-Id: <178119362492.283521.5363393418065361444.b4-review@b4> X-Mailer: b4 0.16-dev X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781193582986 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zone.pm] Message-ID-Hash: 5JKRKSX24YPJXI6K7HQYCKV75OIT4G3R X-Message-ID-Hash: 5JKRKSX24YPJXI6K7HQYCKV75OIT4G3R X-MailFrom: g.goller@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 28 May 2026 15:39:46 +0200, Stefan Hanreich wrote: > When querying the status of EVPN IP/MAC-VRFs, the nodes field of the > zone configuration is read. The nodes are returned as a dictionary, > but the API endpoints are treating the field as an array. This leads > to an error when trying to obtain the status of an EVPN zone with > nodes configured explicitly: > > Not an ARRAY reference at /usr/share/perl5/PVE/API2/Network/SDN/Nodes/Zone.pm line 379. > > [...] Reviewed-by: Gabriel Goller Tested-by: Gabriel Goller -- Gabriel Goller