From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 879C91FF138 for ; Mon, 01 Jun 2026 15:14:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AC5361D8B8; Mon, 1 Jun 2026 15:14:25 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com, Fiona Ebner Subject: applied: [PATCH manager] ui: utils: fix qemu version check to unbreak USB port limit Date: Mon, 1 Jun 2026 15:14:16 +0200 Message-ID: <178031953949.2815883.7722858864032945907.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260601091328.66757-1-f.ebner@proxmox.com> References: <20260601091328.66757-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record T_SPF_PERMERROR 0.01 SPF: test of record failed (permerror) Message-ID-Hash: AJXLBILLAM5QSSAQG4J2OSL4SFZFYBTM X-Message-ID-Hash: AJXLBILLAM5QSSAQG4J2OSL4SFZFYBTM X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 01 Jun 2026 11:12:13 +0200, Fiona Ebner wrote: > The qemu_min_version() helper is only used for the USB port limit > right now. The implementation was wrong, as it wrongly required the > minor version (or micro version if there were such a caller) to be > greater or equal too, even if the major version is already greater. > > Reported by a user in the forum: > [0]: https://forum.proxmox.com/threads/26551/post-855326 > > [...] Applied, thanks! Ironically, not even the example in the comment worked, mea culpa for that. I wish we would have some kind of regression test system for our javascript helpers (renderer, formatter, things like this...) [1/1] ui: utils: fix qemu version check to unbreak USB port limit commit: 3185d429ca30bfffff4f95befeae36f67a531a5f