From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 16BB61FF141 for ; Tue, 19 May 2026 14:40:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5B99665CE; Tue, 19 May 2026 14:40:24 +0200 (CEST) Date: Tue, 19 May 2026 14:40:17 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: applied: [PATCH manager] pve8to9: avoid logging failure when old kernel metapackages are not installed To: Fiona Ebner , pve-devel@lists.proxmox.com References: <20260519085148.42853-1-f.ebner@proxmox.com> <177919313632.1121963.6885264919205134776.b4-ty@proxmox.com> <4321bcaf-dc50-4aad-9684-9dfe4fa16d57@proxmox.com> In-Reply-To: <4321bcaf-dc50-4aad-9684-9dfe4fa16d57@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1779194409.i2i5yvbxpk.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1779194407356 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OAR7ZXS6DLDMK6V2JLH7CV5RIJ5377UP X-Message-ID-Hash: OAR7ZXS6DLDMK6V2JLH7CV5RIJ5377UP X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On May 19, 2026 2:27 pm, Fiona Ebner wrote: > Am 19.05.26 um 2:19 PM schrieb Fabian Gr=C3=BCnbichler: >>=20 >> On Tue, 19 May 2026 10:50:06 +0200, Fiona Ebner wrote: >>> Since the $noerr parameter was not passed along, the get_pkg >>> subroutine would log a failure when it couldn't determine the >>> installed package version for old kernel metapackages, e.g.: >>>> FAIL: unable to determine installed pve-kernel-6.5 version. >>> >>> >>=20 >> Applied to master and stable-8, thanks! >=20 > In stable-8, $get_pkg() does not have the $noerr argument yet. thanks, added that as a follow-up!