From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4F3C91FF146 for ; Tue, 12 May 2026 04:10:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8120027454; Tue, 12 May 2026 04:10:32 +0200 (CEST) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Kefu Chai Subject: applied: [PATCH manager 1/1] ceph: pool: fix pool statistics filter returning wrong pool's data Date: Tue, 12 May 2026 04:09:47 +0200 Message-ID: <177855178706.1260779.17492649606337858168.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260331020739.818888-2-k.chai@proxmox.com> References: <20260331020739.818888-2-k.chai@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778551685273 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ELV6AQIG6V3UIMNR6F5JDXNJLMAKK6EW X-Message-ID-Hash: ELV6AQIG6V3UIMNR6F5JDXNJLMAKK6EW X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 31 Mar 2026 10:07:39 +0800, Kefu Chai wrote: > The condition filtering the 'ceph df' response to the requested pool > had a logic error: > > next if !defined($d->{name}) && !$d->{name} ne "$pool"; > > With '&&', short-circuit evaluation means the name comparison is never > reached when $d->{name} is defined. All entries with a defined name > pass through, and $data->{statistics} ends up holding the stats of > whichever pool appears last in the output. > > [...] Applied, thanks! [1/1] ceph: pool: fix pool statistics filter returning wrong pool's data commit: b0f4269e957a11798479aa3383faa86dd620a5cd