From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id DCDCB1FF13F
	for <inbox@lore.proxmox.com>; Thu, 07 May 2026 11:28:14 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 0FE03113F6;
	Thu,  7 May 2026 11:28:13 +0200 (CEST)
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Kefu Chai <k.chai@proxmox.com>
In-Reply-To: <20260228060103.3267076-2-k.chai@proxmox.com>
References: <20260228060103.3267076-2-k.chai@proxmox.com>
Subject: Re: [PATCH proxmox-backup v1] add default pgettext/npgettext
 implementations to index.hbs
Message-Id: <177814605861.2838764.1508543099746188902.b4-ty@b4>
Date: Thu, 07 May 2026 11:27:38 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-Mailer: b4 0.15.2
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1778145950709
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.003 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: NJZQ3IJCB34USCY4TOFFJTNLXOCJCJ7K
X-Message-ID-Hash: NJZQ3IJCB34USCY4TOFFJTNLXOCJCJ7K
X-MailFrom: t.lamprecht@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: Kefu Chai <tchaikov@gmail.com>
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

On Sat, 28 Feb 2026 14:01:04 +0800, Kefu Chai wrote:
> This adds default implementations for pgettext() and npgettext() functions
> to prevent UI breakage when no language is selected.
> 
> These functions are required for context-aware translations support added
> to the proxmox-i18n tooling.
> 
> Default implementations:
> - pgettext(context, message): Returns message (ignores context)
> - npgettext(context, singular, plural, count): Returns appropriate form
> 
> [...]

Applied, thanks!

[1/1] add default pgettext/npgettext implementations to index.hbs
      commit: 190a0a01aad90dd0a957ca8b19dc6a0798998d2e