From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A9CB41FF141 for ; Mon, 16 Mar 2026 16:10:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8FDDF1E993; Mon, 16 Mar 2026 16:10:58 +0100 (CET) Date: Mon, 16 Mar 2026 16:10:17 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [pve-devel] [PATCH docs 2/2] firmware-updates: add group header to fwupd.conf To: Maximiliano Sandoval References: <20251229133920.40752-1-m.sandoval@proxmox.com> <20251229133920.40752-2-m.sandoval@proxmox.com> <1768488092.j2n0p8hpzt.astroid@yuna.none> In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1773673775.igibui0ihp.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773673780561 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WTY3IE3AU2OOSBOTHGXPXFG7NXRF526T X-Message-ID-Hash: WTY3IE3AU2OOSBOTHGXPXFG7NXRF526T X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Proxmox VE development discussion X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On March 16, 2026 2:52 pm, Maximiliano Sandoval wrote: > Fabian Gr=C3=BCnbichler writes: >=20 >> On December 29, 2025 2:39 pm, Maximiliano Sandoval wrote: >>> After creating a new config file, either as daemon.conf or fwupd.conf >>> with the same contents as the example prior to this commit, the >>> following error will be seen when starting fwupd.service: >>>=20 >>> Failed to load daemon: failed to load engine: Failed to load config: fa= iled to load /etc/fwupd/fwupd.conf: Key file does not start with a group >>>=20 >>> Since there are potentially multiple groups, adding this at the end of >>> the file might result in the key added to the wrong group. The file is >>> also not present by default, so creating it without the header will als= o >>> lead to issues. On the other hand, adding the group multiple times is >>> not an issue. >>>=20 >>> Please see `man 5 fwupd.conf` for more details. >>>=20 >>> Signed-off-by: Maximiliano Sandoval >>> --- >>> firmware-updates.adoc | 1 + >>> 1 file changed, 1 insertion(+) >>>=20 >>> diff --git a/firmware-updates.adoc b/firmware-updates.adoc >>> index 9ca4b6e..b9ca47e 100644 >>> --- a/firmware-updates.adoc >>> +++ b/firmware-updates.adoc >>> @@ -57,6 +57,7 @@ mount point of the EFI partition in `/etc/fwupd/fwupd= .conf`, for example: >>> =20 >>> .File `/etc/fwupd/fwupd.conf` >>> ---- >>> +[fwupd] >>> # Override the location used for the EFI system partition (ESP) path. >>> EspLocation=3D/boot/efi >> >> does this still work/did you actually test this change? >> >> AFAIK, fwupd now requires udisk to lookup the ESP, it is no longer >> possible to override this: >> >> https://bugzilla.proxmox.com/show_bug.cgi?id=3D6654 >=20 > You are right, it does not work. Would it be OK to remove the following > from the documentation >=20 > ``` > That means you must explicitly configure the correct > mount point of the EFI partition in `/etc/fwupd/daemon.conf`, for example= : >=20 > .File `/etc/fwupd/daemon.conf` > ``` >=20 > for now? probably. and we should test whether there are still blockers for udisks2, and/or how to integrate fwupd with proxmox-boot-tool based setups if there still are some..