From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B28FA1FF13B for ; Wed, 11 Mar 2026 18:08:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ECBE7343C5; Wed, 11 Mar 2026 18:08:37 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com, Daniel Kral Subject: applied: [PATCH ha-manager 0/2] fix #7399: check if required rule props are set Date: Wed, 11 Mar 2026 18:06:07 +0100 Message-ID: <177324873128.3691844.8082191608142351429.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260311125008.271334-1-d.kral@proxmox.com> References: <20260311125008.271334-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1773248849461 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.408 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.819 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.903 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IKXP6PBD7C6AJPBQGMDVWF2PH6PJX77K X-Message-ID-Hash: IKXP6PBD7C6AJPBQGMDVWF2PH6PJX77K X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 11 Mar 2026 13:49:34 +0100, Daniel Kral wrote: > The API endpoints allow users to set empty 'nodes' and 'resources' > properties for HA rules, which are not handled by the api schema > verification nor the api handlers themselves. > > PATCH 1 fixes the > > got unexpected error - cannot lookup undefined type! at > /usr/share/perl5/PVE/HA/Config.pm line 232. > > [...] Applied, thanks. Tiny nit: A short hint in 1/2 that not guarding the result of $class->lookup($rule->{type}) anymore is fine, as lookup dies anyway if the plugin cannot be found would have been nice here, but just a detail. [1/2] rules: ensure rule is defined and has type in set_rule_defaults commit: 00a71f147a203d15e952ca016c188e3e8a0cb518 [2/2] api: rules: check for non-empty nodes and resources properties commit: 41603823b12cdc10bb6041b002544795ddd0f91b