From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E73681FF13C for ; Thu, 19 Feb 2026 09:13:03 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 21674D09B; Thu, 19 Feb 2026 09:14:03 +0100 (CET) Date: Thu, 19 Feb 2026 09:13:54 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [pve-devel] [PATCH common, container, manager and pmg-api v2 0/4] Fix #7175: replace timezone handling with systemd timedatectl To: pve-devel@lists.proxmox.com, Stefan Mayr References: <20260125210151.1151-1-stefan@mayr-stefan.de> <7b42c9a6-98fe-41c9-926b-b11d35f1e700@mayr-stefan.de> In-Reply-To: <7b42c9a6-98fe-41c9-926b-b11d35f1e700@mayr-stefan.de> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1771488809.jsn0vgncfe.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1771488828235 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: F3FRF4GLNZ3IDALJSIZGHHCUXACB2P3J X-Message-ID-Hash: F3FRF4GLNZ3IDALJSIZGHHCUXACB2P3J X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On February 18, 2026 8:53 pm, Stefan Mayr wrote: > Am 25.01.2026 um 22:01 schrieb Stefan Mayr: >> Second try to fix #7175. These patches remove direct /etc/timezone >> handling, add timezone functions to the Systemd module and replaces all >> uses of the functions you pointed me to. >>=20 >> This time it is with a verification of valid timezones. >>=20 >> It does not address hardcoded timezones in the javascript for the UI or >> the rust code handling timezones. >>=20 >> Trying to provide patches to Proxmox is the first time I have to use >> an email based patch workflow. I'm pretty sure sending these patches for >> four different repos the way I do it currently is not 100% how it is >> intended to be done. So please forgive me. >>=20 >> Suggested-by: Fabian Gr=C3=BCnbichler >> Suggested-by: Maximiliano Sandroval >> Signed-off-by: Stefan Mayr >=20 > Any feedback on my suggestions to fix the timezone handling? Sorry, I haven't gotten around yet to doing another pass over it, I'll try to fit it in this week or start of the next one! Fabian