From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 47CD51FF13B for ; Wed, 11 Feb 2026 14:49:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 80A861D93D; Wed, 11 Feb 2026 14:49:48 +0100 (CET) Date: Wed, 11 Feb 2026 14:49:40 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH manager 2/2] ui: lxc/MPEdit: add "keepattrs" flag To: Filip Schauer , pve-devel@lists.proxmox.com References: <20260211110657.50811-1-f.schauer@proxmox.com> <20260211110657.50811-3-f.schauer@proxmox.com> In-Reply-To: <20260211110657.50811-3-f.schauer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1770817692.il72sr0e6w.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770817697858 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GK5NKXCMW44P2AFV7VHJIGTUZYN3NVZP X-Message-ID-Hash: GK5NKXCMW44P2AFV7VHJIGTUZYN3NVZP X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On February 11, 2026 12:06 pm, Filip Schauer wrote: > Expose the "keepattrs" flag for mount points in the UI. >=20 > Signed-off-by: Filip Schauer Reviewed-by: Fabian Gr=C3=BCnbichler > --- > This depends on patch 1/2. >=20 > www/manager6/lxc/MPEdit.js | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js > index f4c45876..4bba536c 100644 > --- a/www/manager6/lxc/MPEdit.js > +++ b/www/manager6/lxc/MPEdit.js > @@ -47,6 +47,7 @@ Ext.define('PVE.lxc.MountPointInputPanel', { > setMPOpt('ro', values.ro); > setMPOpt('acl', values.acl); > setMPOpt('replicate', values.replicate); > + setMPOpt('keepattrs', values.keepattrs); > =20 > let res =3D {}; > res[confid] =3D PVE.Parser.printLxcMountPoint(me.mp); > @@ -338,6 +339,20 @@ Ext.define('PVE.lxc.MountPointInputPanel', { > name: 'replicate', > fieldLabel: gettext('Skip replication'), > }, > + { > + xtype: 'proxmoxcheckbox', > + name: 'keepattrs', > + defaultValue: '0', > + fieldLabel: gettext('Keep Attributes'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Preserve Attributes of Target Dire= ctory'), nit: this is not a heading/label, so it should have regular casing? > + }, > + bind: { > + hidden: '{isRoot}', > + disabled: '{isRoot}', > + }, > + }, > ], > }); > =20 > --=20 > 2.47.3 >=20 >=20 >=20 >=20 >=20 >=20