From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 5B36A1FF13B for ; Wed, 11 Feb 2026 14:49:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 97B761D9E6; Wed, 11 Feb 2026 14:49:54 +0100 (CET) Date: Wed, 11 Feb 2026 14:49:42 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH container 1/2] make mount point attribute preservation configurable To: Filip Schauer , pve-devel@lists.proxmox.com References: <20260211110657.50811-1-f.schauer@proxmox.com> <20260211110657.50811-2-f.schauer@proxmox.com> In-Reply-To: <20260211110657.50811-2-f.schauer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1770817432.uyvsv72z01.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1770817699530 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.048 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 432OSWXPW45DVEMZSBGEV2MJ7BGLM4GA X-Message-ID-Hash: 432OSWXPW45DVEMZSBGEV2MJ7BGLM4GA X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On February 11, 2026 12:06 pm, Filip Schauer wrote: > The commit 0db559517ac6 (mountpoint_insert_staged: inherit attributes if > directory already exists) introduced automatic propagation of uid, gid, > and mode from the target directory to the mounted filesystem. While this > improves compatibility with some OCI images, it also caused undesired > ownership changes on some mount points. >=20 > Since attribute preservation is not always desired, make this behavior > configurable via a new "keepattrs" mountpoint flag. Default to disabled > to preserve historical behavior. >=20 > Signed-off-by: Filip Schauer Reviewed-by: Fabian Gr=C3=BCnbichler > --- > src/PVE/LXC.pm | 4 +--- > src/PVE/LXC/Config.pm | 6 ++++++ > src/lxc-pve-prestart-hook | 2 +- > 3 files changed, 8 insertions(+), 4 deletions(-) >=20 > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index 41ea991..2c02e9a 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -2478,10 +2478,8 @@ sub mountpoint_hotplug : prototype($$$$$) { > chdir('/') > or die "failed to change root directory within the container= 's mount namespace: $!\n"; > =20 > - my $keep_attrs =3D $mp->{type} eq 'volume'; > - > mountpoint_insert_staged( > - $mount_fd, undef, $mp->{mp}, $opt, $root_uid, $root_gid, $ke= ep_attrs, > + $mount_fd, undef, $mp->{mp}, $opt, $root_uid, $root_gid, $mp= ->{keepattrs}, > ); > }); > } > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm > index 6f54e9f..0090d61 100644 > --- a/src/PVE/LXC/Config.pm > +++ b/src/PVE/LXC/Config.pm > @@ -987,6 +987,12 @@ my $mp_desc =3D { > verbose_description =3D> "Path to the mount point as seen from i= nside the container.\n\n" > . "NOTE: Must not contain any symlinks for security reasons.= ", > }, > + keepattrs =3D> { > + type =3D> 'boolean', > + description =3D> 'Inherit attributes from the target path, if it= exists already.', nit: "target path" is not a term we've used here in the past.. the usual term for this directory is "mountpoint".=20 maybe s/target path/mountpoint directory/ here? _maybe_ we could also spell out what "attributes" means here? > + optional =3D> 1, > + default =3D> 0, > + }, > }; > PVE::JSONSchema::register_format('pve-ct-mountpoint', $mp_desc); > =20 > diff --git a/src/lxc-pve-prestart-hook b/src/lxc-pve-prestart-hook > index f900c12..9862509 100755 > --- a/src/lxc-pve-prestart-hook > +++ b/src/lxc-pve-prestart-hook > @@ -100,7 +100,7 @@ PVE::LXC::Tools::lxc_hook( > # Mount relative to the rootdir fd. > $dest_base_fd =3D $rootdir_fd; > $dest_dir =3D './' . $mountpoint->{mp}; > - $keep_attrs =3D $mountpoint->{type} eq 'volume'; > + $keep_attrs =3D $mountpoint->{keepattrs}; > } else { > # Assert that 'rootfs' is the first one: > die "foreach_mount() error\n" if $opt ne 'rootfs'; > --=20 > 2.47.3 >=20 >=20 >=20 >=20 >=20 >=20