From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 343B61FF140 for ; Thu, 15 Jan 2026 15:20:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E00F3E6A; Thu, 15 Jan 2026 15:20:36 +0100 (CET) Date: Thu, 15 Jan 2026 15:19:58 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox VE development discussion References: <20251219152009.862325-1-m.sandoval@proxmox.com> In-Reply-To: <20251219152009.862325-1-m.sandoval@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1768486661.9u9pts34rj.astroid@yuna.none> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768486753341 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH container] fix #6392: setup: fedora: skip --prompt-new-user on firstboot X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On December 19, 2025 4:19 pm, Maximiliano Sandoval wrote: > As per 'homectl --help': > > --prompt-new-user: Query user interactively for user to create > > which will wait on stdin to get the credentials for the new user, but at > this point there is no way for the user to enter such input and the > container will not start. > > One could alternatively remove the unit file from the > 'systemd-firstboot(1)' step, but this incantation has valid use-cases > like recognizing a existing homes on firstboot. 1. this makes no sense in the commit message ;) 2. I don't think homed integration makes a lot of sense for a system container, and would rather skip it altogether > Signed-off-by: Maximiliano Sandoval > --- > src/PVE/LXC/Setup/Fedora.pm | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/src/PVE/LXC/Setup/Fedora.pm b/src/PVE/LXC/Setup/Fedora.pm > index cf383e3..891884b 100644 > --- a/src/PVE/LXC/Setup/Fedora.pm > +++ b/src/PVE/LXC/Setup/Fedora.pm > @@ -43,6 +43,30 @@ sub setup_init { > 'systemd-networkd.service' => 1, > }); > } > + > + if ($version >= 42) { > + $self->skip_homectl_firstboot_prompt(); > + } > +} > + > +sub skip_homectl_firstboot_prompt { > + my ($self) = @_; > + > + # Replaces 'homectl firstboot --prompt-new-user' with 'homectl firstboot'. > + # When the --prompt-new-user flag is enabled the process will wait for user > + # input resulting in the setup process not ever finishing. > + my $unit_path = '/usr/lib/systemd/system/systemd-homed-firstboot.service'; > + if ($self->ct_file_exists($unit_path)) { > + my $unit = <<__EOD__; > +# Generated by Proxmox VE > +[Service] > +ExecStart= > +ExecStart=homectl firstboot > +__EOD__ > + > + $self->ct_make_path("$unit_path.d"); > + $self->ct_file_set_contents("$unit_path.d/50-skip-prompt.conf", $unit); > + } > } > > sub setup_network { > -- > 2.47.3 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > > > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel