From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 16E7A1FF17E for ; Thu, 11 Dec 2025 15:23:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9A6D17A85; Thu, 11 Dec 2025 15:24:01 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com, Filip Schauer Date: Thu, 11 Dec 2025 15:23:11 +0100 Message-ID: <176546279552.187736.15722520165979478484.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251119135323.102447-1-f.schauer@proxmox.com> References: <20251119135323.102447-1-f.schauer@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1765463006708 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager v2 0/2] ui: storage oci pull: optimize and cleanup reference regex X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Wed, 19 Nov 2025 14:52:27 +0100, Filip Schauer wrote: > Changed in v2: > * remove unnecessary backslashes from regex ("\\/" becomes "/") > * ran `make tidy` > > Filip Schauer (2): > ui: storage oci pull: optimize reference regex > ui: storage oci pull: split up long one-line regex > > [...] Applied, thanks! But maybe it would be more readable by using (string) variables for the parts and re-use them where applicable when concatenating the full string for the expression. Or is there a better way to build regexes in JavaScript from smaller parts? E.g. '[a-zA-Z\\d](?:[a-zA-Z\\d-]*[a-zA-Z\\d])?' could be a variable and '[a-z\\d]+(?:(?:[._]|__|-+)[a-z\\d]+)*' could be one, both being used twice if I'm not misreading it. And more could make sense like '\\w[\\w.-]{0,127}' just to give that part a name too when constructing the full regex. [1/2] ui: storage oci pull: optimize reference regex commit: 9fe9aa05f70cdaf98fa0c51d233125beb0467f2c [2/2] ui: storage oci pull: split up long one-line regex commit: d336324550daadb28f4fedbd8f05dbcb53427cc2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel